Capture stdout/stderr in server test and align completion timing #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manzt
force-pushed
the
push-yozmrmslkkvz
branch
from
1885e31 to
a28d344
Compare
mscolnick
approved these changes
Sep 10, 2025
manzt
force-pushed
the
push-yozmrmslkkvz
branch
4 times, most recently
from
671bf35 to
8186d35
Compare
Update the language server test cell code to use stdout/stderr. Inserts a short 20ms delay before setting the completion event to ensure we capture the stdout/stderr, which are buffered and flushed every 10ms. Ideally, we could flush prior to the "idle" cell-op for each cell run, but that requires more complicated upstream change so this works for now. We will do the same thing in the extension front end.
manzt
force-pushed
the
push-yozmrmslkkvz
branch
from
8186d35 to
ec5fc65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the language server test cell code to use stdout/stderr. Inserts
a 100ms delay before setting the completion event to ensure we
capture the stdout/stderr, which are buffered and flushed every 10ms.
Ideally, we could flush prior to the "idle" cell-op for each cell run,
but that requires more complicated upstream change so this works for
now. We will do the same thing (maybe 50ms) in the extension front end.