Set kernel working directory to notebook's directory #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #171 Previously, `pathlib.Path.cwd()` returned the LSP server's working directory (`extension/dist`) instead of the notebook's directory. This caused relative file paths to resolve incorrectly, breaking notebooks that relied on local file access with libraries like `pandas`, `polars`, etc. The kernel subprocess now inherits the notebook's directory as its working directory, ensuring `cwd` and relative paths work as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #171
Previously,
pathlib.Path.cwd()returned the LSP server's working directory (extension/dist) instead of the notebook's directory. This caused relative file paths to resolve incorrectly, breaking notebooks that relied on local file access with libraries likepandas,polars, etc.The kernel subprocess now inherits the notebook's directory as its working directory, ensuring
cwdand relative paths work as expected.