Skip to content

Use cross-platform NodePath.join to get executable #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
Merged

Use cross-platform NodePath.join to get executable #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions extension/src/services/SandboxController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import * as NodePath from "node:path";
import * as semver from "@std/semver";
import { Effect, Option, Runtime, Schema } from "effect";
import type * as vscode from "vscode";
Expand Down Expand Up @@ -46,9 +47,9 @@ export class SandboxController extends Effect.Service<SandboxController>()(
);
}

// always make sure the env is up to date
// always ensure the env is up to date
const venv = yield* uv.sync({ script: notebook.uri.fsPath });
const executable = `${venv}/bin/python`;
const executable = NodePath.join(venv, "bin", "python");
yield* python.updateActiveEnvironmentPath(executable);

yield* client.executeCommand({
Expand Down