Skip to content

Conversation

@tschm
Copy link
Contributor

@tschm tschm commented Jun 12, 2025

@mscolnick
I have done a few things here

I have removed the requirements.txt file and simplified the ci/cd process with relying on uvx and dependency preambles.
I made your webpage really fancy (done by Junie tbh)
Removed your build.py construction. The loops etc are performed directly in the workflows.
Added a Makefile to experiment with the export functionality locally.
Cleaned up your notebooks (now with app.setup, dependency preamble, and app.function)

tschm added 14 commits June 12, 2025 15:07
* Example with Pandas

* Pandas example

* works for pandas

* ignore __marimo__

* Update Makefile

* Update penguins.py

* Update pandas_penguins.py

* Update fibonacci.py

* Update charts.py

* Update Makefile

* Update deploy.yml

* notebooks with preamble

* deploy workflow

* Update deploy.yml

* Update deploy.yml

* Update deploy.yml
uses: actions/setup-python@v5
with:
python-version: 3.12 # Use Python 3.12 for the build
# Convert all Marimo notebooks to HTML-WASM format
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice if this didn't exist in CI so its easy to test and change. and it was callable by scripts

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what was wrong with running it as a python script?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the Python scripts distract too much from the actual content, e.g. you are spending several lines to construct the command which is then called in a subprocess action. This is clearer when performed directly in bash in the first place. Obviously both approaches are equivalent (although I am using a slightly different convention to store the exported notebooks). For testing purposes you could use make app APPS=charts or make notebook NOTEBOOK=penguin...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a regression that now the HTML file needs to be manually added for each notebook. that is fine (maybe hte user wants more configurability), but just calling it out

@mscolnick mscolnick merged commit 5f38965 into marimo-team:main Jun 12, 2025
mscolnick added a commit that referenced this pull request Jun 12, 2025
mscolnick added a commit that referenced this pull request Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants