-
Notifications
You must be signed in to change notification settings - Fork 84
Modern marimo and a fancy webpage #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Example with Pandas * Pandas example * works for pandas * ignore __marimo__ * Update Makefile * Update penguins.py * Update pandas_penguins.py * Update fibonacci.py * Update charts.py * Update Makefile * Update deploy.yml * notebooks with preamble * deploy workflow * Update deploy.yml * Update deploy.yml * Update deploy.yml
.github/workflows/deploy.yml
Outdated
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: 3.12 # Use Python 3.12 for the build | ||
| # Convert all Marimo notebooks to HTML-WASM format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be nice if this didn't exist in CI so its easy to test and change. and it was callable by scripts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what was wrong with running it as a python script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the Python scripts distract too much from the actual content, e.g. you are spending several lines to construct the command which is then called in a subprocess action. This is clearer when performed directly in bash in the first place. Obviously both approaches are equivalent (although I am using a slightly different convention to store the exported notebooks). For testing purposes you could use make app APPS=charts or make notebook NOTEBOOK=penguin...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a regression that now the HTML file needs to be manually added for each notebook. that is fine (maybe hte user wants more configurability), but just calling it out
This reverts commit 5f38965.
@mscolnick
I have done a few things here
I have removed the requirements.txt file and simplified the ci/cd process with relying on uvx and dependency preambles.
I made your webpage really fancy (done by Junie tbh)
Removed your build.py construction. The loops etc are performed directly in the workflows.
Added a Makefile to experiment with the export functionality locally.
Cleaned up your notebooks (now with app.setup, dependency preamble, and app.function)