refactor(functors): v0.1.4 of notebook functors for fp course #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 3, 2025 06:11
* restructure the notebook * replace `f` in the function signatures with `g` to indicate regular functions and distinguish from functors
* move `Maybe` funtor to section `More Functor instances` + add `Either` functor + add `unzip` utility function for functors
Collaborator
|
@metaboulie Is this up for review or should I be waiting for more commits? |
Author
|
@Haleshot There are some significant changes for |
Collaborator
|
Tracking: In relation to #51 |
Author
|
@Haleshot This PR is stable and ready to be reviewed🥳 |
Haleshot
reviewed
Apr 18, 2025
Haleshot
reviewed
Apr 18, 2025
Haleshot
reviewed
Apr 18, 2025
| return | ||
|
|
||
|
|
||
| @app.cell(hide_code=True) |
Collaborator
There was a problem hiding this comment.
Any reason for unhiding this cell block?
Haleshot
reviewed
Apr 18, 2025
Haleshot
previously approved these changes
Apr 18, 2025
Collaborator
Haleshot
left a comment
Haleshot
left a comment
There was a problem hiding this comment.
Great changes on the whole!
Co-authored-by: Srihari Thyagarajan <[email protected]>
ghost
dismissed
Co-authored-by: Srihari Thyagarajan <[email protected]>
Co-authored-by: Srihari Thyagarajan <[email protected]>
Author
|
All suggestions committed, thanks for your review |
Haleshot
approved these changes
Apr 20, 2025
Collaborator
Haleshot
left a comment
Haleshot
left a comment
There was a problem hiding this comment.
LGTM! Thanks for great changes and for keeping this series going ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Migrate to
python3.13Replace all occurrences of
with
for conciseness
Use
fain function signatures instead ofawhenfais a Functorfin the function signatures withgto indicate regular functions and distinguish from functorsMaybefuntor to sectionMore Functor instancesEitherfunctorunziputility function for functors📋 Checklist
--sandboxREADME.md