-
Notifications
You must be signed in to change notification settings - Fork 37
Add Polars Reactive plots notebook #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Forgot to link the issue, #40 |
|
Really liked this notebook! Great dataset chosen for the topic at hand; each cell block walks through and conveys a story (imo); the comments are really descriptive and I enjoyed that. Thanks a lot for the contribution ❤️ Will see if there are any other things that I missed out on (a little late here, will look into this tomorrow). |
|
@etrotta Hope you had a chance to go over the above review comments; can totally understand if you've been busy (work/otherwise). Let me know if you need any help w/ this notebook/PR. |
|
@Haleshot I moved the imports a while ago, but I am not sure what else was missing besides that? I was waiting for suggestions regarding the balance I mentioned in the other comment before splitting anything as for me the way it stands today is good enough, but more importantly I assumed you'd add more comments after
If you used GitHub's review feature, maybe check if you forgot to Submit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR review comments
Ah 🙈 thanks a lot for this, forgot to submit them. Hope they're visible now. |
|
Hey! Just wanted to check in real quick — were you able to take a look at the review comments on the PR? (They should be showing up now 🤞). |
Yes, I can see it now |
Co-authored-by: Srihari Thyagarajan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great contribution. Was a nice dataset to choose for showcasing relevant plots! Thanks a lot!
|
Looks like there are some typos (failing CIs). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the high-quality notebook contrib!
📝 Summary
Add a Notebook for the Polars course, covering data visualization using marimo interactive plotting elements
📋 Checklist
--sandboxREADME.md