Skip to content

Conversation

@etrotta
Copy link
Contributor

@etrotta etrotta commented Mar 23, 2025

📝 Summary

Add a Notebook for the Polars course, covering data visualization using marimo interactive plotting elements

📋 Checklist

  • I have included package dependencies in the notebook file using --sandbox
  • If adding a course, include a README.md
  • Keep language direct and simple.

@etrotta
Copy link
Contributor Author

etrotta commented Mar 23, 2025

Forgot to link the issue, #40

@Haleshot Haleshot self-assigned this Mar 24, 2025
@Haleshot Haleshot added the enhancement New feature or request label Mar 24, 2025
@Haleshot Haleshot removed their assignment Mar 24, 2025
@Haleshot
Copy link
Collaborator

Haleshot commented Mar 24, 2025

Really liked this notebook! Great dataset chosen for the topic at hand; each cell block walks through and conveys a story (imo); the comments are really descriptive and I enjoyed that. Thanks a lot for the contribution ❤️

Will see if there are any other things that I missed out on (a little late here, will look into this tomorrow).

@Haleshot
Copy link
Collaborator

Haleshot commented Apr 6, 2025

@etrotta Hope you had a chance to go over the above review comments; can totally understand if you've been busy (work/otherwise). Let me know if you need any help w/ this notebook/PR.

@etrotta
Copy link
Contributor Author

etrotta commented Apr 6, 2025

@Haleshot I moved the imports a while ago, but I am not sure what else was missing besides that?

I was waiting for suggestions regarding the balance I mentioned in the other comment before splitting anything as for me the way it stands today is good enough, but more importantly I assumed you'd add more comments after

Will see if there are any other things that I missed out on (a little late here, will look into this tomorrow)

If you used GitHub's review feature, maybe check if you forgot to Submit?

Copy link
Collaborator

@Haleshot Haleshot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR review comments

@Haleshot
Copy link
Collaborator

Haleshot commented Apr 7, 2025

If you used GitHub's review feature, maybe check if you forgot to Submit?

Ah 🙈 thanks a lot for this, forgot to submit them. Hope they're visible now.

@Haleshot
Copy link
Collaborator

Hey! Just wanted to check in real quick — were you able to take a look at the review comments on the PR? (They should be showing up now 🤞).

@etrotta
Copy link
Contributor Author

etrotta commented Apr 11, 2025

Hey! Just wanted to check in real quick — were you able to take a look at the review comments on the PR? (They should be showing up now 🤞).

Yes, I can see it now
I'll make the requested changes tonight or this weekend

etrotta and others added 2 commits April 18, 2025 15:08
@etrotta etrotta requested a review from Haleshot April 18, 2025 18:36
Haleshot
Haleshot previously approved these changes Apr 20, 2025
Copy link
Collaborator

@Haleshot Haleshot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution. Was a nice dataset to choose for showcasing relevant plots! Thanks a lot!

@Haleshot
Copy link
Collaborator

Looks like there are some typos (failing CIs).

Copy link
Collaborator

@Haleshot Haleshot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the high-quality notebook contrib!

@Haleshot Haleshot merged commit 8cc48bf into marimo-team:main Apr 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants