refactor: 改进容器检查逻辑的类型安全性和健壮性 #2622
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
变更内容
本次 PR 优化了容器检查逻辑,主要变更包括:
?.)替代显式的 null 检查instanceof HTMLElement进行类型检查替代@ts-expect-errorclassList.contains()替代直接访问classNamefirstChild变量提高代码可读性变更原因
@ts-expect-error绕过类型检查,存在潜在风险className不够健壮,无法处理多个类名的情况影响范围
此变更仅影响初始化时的容器检查逻辑,不会改变功能行为,但提高了代码的:
测试建议
maptalks-wrapper类时的错误抛出