Use self.init instead of setting member variables directly. #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This way if the initializer should change, it will be a little more obvious for this client when re-building.
Archdoog
approved these changes
Apr 25, 2025
Collaborator
Archdoog
left a comment
Archdoog
left a comment
There was a problem hiding this comment.
This is definitely a little easier to follow 👍
bolsinga
added a commit
to bolsinga/swiftui-dsl
that referenced
this pull request
Apr 25, 2025
- Typically in an application, there is one MNMapView. When using CarPlay, there are two. This helps debugging the scenario so that two views can be distinguished from each other when debugging. - It sets the `UIView.tag` property of the `MLNMapView` to the enum's rawValue. It also exists in its enumerated type elsewhere. Depends upon maplibre#80
5 tasks
ianthetechie
approved these changes
Apr 28, 2025
Collaborator
ianthetechie
left a comment
ianthetechie
left a comment
There was a problem hiding this comment.
Good change; thanks!
ianthetechie
added a commit
that referenced
this pull request
Apr 28, 2025
* Use self.init instead of setting member variables directly. - This way if the initializer should change, it will be a little more obvious for this client when re-building. * Add MapActivity to track what MapView is being used for. - Typically in an application, there is one MNMapView. When using CarPlay, there are two. This helps debugging the scenario so that two views can be distinguished from each other when debugging. - It sets the `UIView.tag` property of the `MLNMapView` to the enum's rawValue. It also exists in its enumerated type elsewhere. Depends upon #80 --------- Co-authored-by: Ian Wagner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Motivation
MapViewinitializer should change, it will be a little more obvious for this client when re-building.What issue is this PR targeting?
None
Tasklist