support CLLocationDirection/course for bearing #428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianrex
approved these changes
Jun 3, 2021
neelmistry94
force-pushed
the
nm/location_support_course
branch
from
b27f061 to
7ef4b67
Compare
adding back correct puck image support course via options merge conflict update puckBearingSource so that it is a stored property of Puck fix broken tests test that puck bearing source propogates changes from manager to puck clearing up docs and formatting remove unneeded function build fix prevent premature creation of puck
neelmistry94
force-pushed
the
nm/location_support_course
branch
from
12d4135 to
68a138d
Compare
nishant-karajgikar
approved these changes
Jun 7, 2021
added 2 commits
June 7, 2021 17:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: An issue where location puck was not tracking course
Pull request checklist:
Summary of changes
This change brings the support for
coursewhen updating thelocationPuck. There is a new option that the developer can specify whether the bearing should be updated viaheading: CLHeadingor viacourse: CLLocationDirection