Skip to content

Conversation

@evil159
Copy link
Contributor

@evil159 evil159 commented Sep 30, 2024

What does this pull request do?

This PR adds proxying Mapbox Maps SDK logs from platform to flutter side in debug configuration to print them in debug console with log() function from dart:developer package.

Logs are proxied only in debug configuration and can be disabled completely by passing environment flag MAPBOX_LOG_DEBUG with false value.

What is the motivation and context behind this change?

Easier debugging experience.

Pull request checklist:

  • Add a changelog entry.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add documentation comments for any added or updated public APIs.

@evil159 evil159 requested review from a team as code owners September 30, 2024 13:44
@evil159 evil159 requested a review from pjleonard37 September 30, 2024 13:44
@evil159 evil159 enabled auto-merge (squash) September 30, 2024 15:41
final geometry = RenderedQueryGeometry.fromScreenCoordinate(screenCoordinate);
```
* Bump Maps SDK to 11.7.0.
* Print to console native Maps SDK logs in debug configuration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add a note explaining how to turn this off here.

@evil159 evil159 merged commit a3ce579 into main Sep 30, 2024
@evil159 evil159 deleted the rl/debug_logging branch September 30, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants