Remove workaround for mosaic client updates (and flickering in UI) #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The manual listener for `filterBy` changes is no longer needed with the latest mosaic. The coordinator now properly handles `Selection` updates and triggers query/queryResult calls when filterBy is updated.
manzt
force-pushed
the
push-qzrtmkmmxksv
branch
from
20c1bdd to
d8c0597
Compare
manzt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More code elimination!
The manual listener for
filterBychanges is no longer needed with the latest mosaic and was causing flickering. The coordinator now properly handlesSelectionupdates and triggers query/queryResult calls whenfilterByis updated.