Fix read_dsrecord_from_json, which was not keeping names#414
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes read_dsrecord_from_json so that applying overhangs no longer drops metadata (notably the sequence name) when converting a TextFileSequence GenBank payload back into a Dseqrecord.
Changes:
- Stop reconstructing a new
Dseqrecordwhen overhangs are present; instead update the parsed record’sseqwith the requested overhangs. - Preserve parsed GenBank metadata (e.g., name/annotations/features) by keeping the original
Dseqrecordinstance.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
manulera
added a commit
that referenced
this pull request
Mar 6, 2026
manulera
added a commit
that referenced
this pull request
Mar 6, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #414 +/- ##
==========================================
- Coverage 97.07% 97.07% -0.01%
==========================================
Files 31 31
Lines 1985 1984 -1
==========================================
- Hits 1927 1926 -1
Misses 58 58
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.