Skip to content

Deal with base count misplaced#410

Merged
manulera merged 3 commits intomasterfrom
deal-with-BASE_COUNT
Mar 3, 2026
Merged

Deal with base count misplaced#410
manulera merged 3 commits intomasterfrom
deal-with-BASE_COUNT

Conversation

@manulera
Copy link
Owner

@manulera manulera commented Mar 3, 2026

Temp fix waiting for biopython/biopython#5173


Note

Medium Risk
Changes GenBank parsing behavior by pre-filtering input lines, which could mask malformed files or subtly alter downstream parsing; impact is limited to genbank imports and covered by a new regression test.

Overview
Adds a temporary workaround in custom_file_parser for GenBank files by stripping any BASE COUNT lines (even if misplaced) before running Bio.SeqIO.parse, avoiding Biopython parsing failures.

Adds a regression test and fixture (base_count_misplaced.gb) to ensure such files can be parsed successfully.

Written by Cursor Bugbot for commit 1d71d81. This will update automatically on new commits. Configure here.

@manulera manulera merged commit ab6b331 into master Mar 3, 2026
12 checks passed
@manulera manulera deleted the deal-with-BASE_COUNT branch March 3, 2026 08:24
@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.03%. Comparing base (4a00fef) to head (1d71d81).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #410   +/-   ##
=======================================
  Coverage   97.03%   97.03%           
=======================================
  Files          31       31           
  Lines        1953     1959    +6     
=======================================
+ Hits         1895     1901    +6     
  Misses         58       58           
Flag Coverage Δ
unittests 97.03% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant