Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #410 +/- ##
=======================================
Coverage 97.03% 97.03%
=======================================
Files 31 31
Lines 1953 1959 +6
=======================================
+ Hits 1895 1901 +6
Misses 58 58
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temp fix waiting for biopython/biopython#5173
Note
Medium Risk
Changes GenBank parsing behavior by pre-filtering input lines, which could mask malformed files or subtly alter downstream parsing; impact is limited to
genbankimports and covered by a new regression test.Overview
Adds a temporary workaround in
custom_file_parserfor GenBank files by stripping anyBASE COUNTlines (even if misplaced) before runningBio.SeqIO.parse, avoiding Biopython parsing failures.Adds a regression test and fixture (
base_count_misplaced.gb) to ensure such files can be parsed successfully.Written by Cursor Bugbot for commit 1d71d81. This will update automatically on new commits. Configure here.