Add System32 to search paths for Dawn on Windows #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuel5975p
requested changes
Dec 5, 2025
| #endif | ||
| } | ||
|
|
||
| #ifdef WEBGPU_BACKEND_DAWN |
Owner
There was a problem hiding this comment.
Can you change this to #if SUPPORT_WGPU_BACKEND == 1 for now?
| // Define DawnInstanceDescriptor from DawnNative.h | ||
|
|
||
| #ifndef WGPUSType_DawnInstanceDescriptor | ||
| #define WGPUSType_DawnInstanceDescriptor (WGPUSType)0x000003EC |
Owner
There was a problem hiding this comment.
Does this work or cause an "invalid SType ..." error?
Contributor
Author
There was a problem hiding this comment.
It doesn't work yeah. Not really sure what to do, maybe we do need a C++ file (like with the Tint parser) just for this.
Peter0x44
reviewed
Dec 11, 2025
Contributor
Author
|
superseded by #29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default dawn only searches for vulkan-1.dll in the executable folder, this also makes it search in system32 on windows.
TODO: verify memory safety