Skip to content

Conversation

@jcrugzz
Copy link
Contributor

@jcrugzz jcrugzz commented Apr 27, 2016

Discovered this in the process of attempting to fix a "bug" in #137

@mantoni
Copy link
Owner

mantoni commented Apr 28, 2016

Thanks. It's slightly worrying that the stack disappears. Any idea why?

@jcrugzz
Copy link
Contributor Author

jcrugzz commented May 4, 2016

@mantoni the stack didnt disappear, it just includes a longer stacktrace more thorough stacktrace. it didnt seem advantageous to test that particular string output as it causes false positive failures like i found here when a new version was installed. We dont need to be coupled that strictly to the string output, just acknowledge the passing or failing.

@mantoni mantoni merged commit 28aaf69 into mantoni:master Jul 19, 2016
@mantoni
Copy link
Owner

mantoni commented Jul 19, 2016

Sorry for keeping this open for so long. I was still stuck with PhantomJS 1.9 and therefore the test cases didn't fail for me and I couldn't really verify this properly. Thanks for looking into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants