[@mantine.hook] feat handle writing-mode in useResizeObserver for accurate box size calculation #7764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urate box size calculation (mantinedev#7582) - add use-resize-observer.test.tsx - add UseResizeObserver.story.tsx
Han5991
force-pushed
the
feature/fix-useResizeObserver
branch
from
fd2a7a5 to
3792955
Compare
rtivital
requested changes
Apr 30, 2025
packages/@mantine/hooks/src/use-resize-observer/use-resize-observer.ts
Outdated
Show resolved
Hide resolved
- remove window.getComputedStyle - rect x,y,top,left,right,bottom update
Han5991
force-pushed
the
feature/fix-useResizeObserver
branch
from
b0b4cbe to
3664e79
Compare
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #7582
Changes
borderBoxSizeorcontentBoxSizefromResizeObserverEntryinstead ofcontentRectcontentRectfor backward compatibility