Add verbose output of file offsets and virtual addresses for language-specific strings#1019
Draft
Arker123 wants to merge 4 commits intomandiant:masterfrom
Draft
Add verbose output of file offsets and virtual addresses for language-specific strings#1019Arker123 wants to merge 4 commits intomandiant:masterfrom
Arker123 wants to merge 4 commits intomandiant:masterfrom
Conversation
Collaborator
|
do you think we should add column headers? |
mr-tz
reviewed
Jun 24, 2024
Collaborator
mr-tz
left a comment
mr-tz
left a comment
There was a problem hiding this comment.
how does this handle strings outside of .rdata?
alternative, we could consider adding a virtual offset field (and section info) to the StaticString class
Collaborator
Author
|
Currently looks like this in verbose:- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the verbose output to display raw file offsets and virtual addresses for Rust strings.
Fixes: #925 #937
*The PR is in draft status because it currently only supports Rust strings.