Support clang++ from conda-forge #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
jjerphan
changed the title
Collaborator
JohanMabille
left a comment
JohanMabille
left a comment
There was a problem hiding this comment.
We discussed dropping support for Apple Clang, is it still relevant? If so, we should probably remove the corresponding macro; otherwise, we should have an additional parameter in the matrix build to test bothe Apple Clang and clang 17.
Signed-off-by: Julien Jerphanion <[email protected]> Co-authored-by: Johan Mabille <[email protected]>
jjerphan
changed the title
jjerphan
force-pushed
the
libc++16-support
branch
from
2193a2c to
5777bb4
Compare
Signed-off-by: Julien Jerphanion <[email protected]>
JohanMabille
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even-though conda-forge's toolchain allows for using clang++ 18, libc++ 16 is the latest version available (see conda-forge/libcxx-feedstock#131).
The
std::lexicographical_compare_three_wayhas only been implemented in libc++ 17, so we use the vendored implementation when libc++ < 17 is used.