Conversation
when we use subdomains as registered domain like `dns.domain.com` there is a logical error, i try to fix it very simply. the reason of using three level domain name is that: dns.domain.com has a ns record to dnsfookupServerIP.domain.com which any subdomain of *.dns.domain.com will ask their records from dnsfookupServerIP.domain.com, so it is easily possible with this commit to only with having one domain we use dnsfookup as a production/publicly available server
Update dns.py
maybe the users set host_domain like `domain.com.` which an additional . or extra space character is added, we want to sure that there isn't any further problem about this.
makuga01
reviewed
May 19, 2023
makuga01
reviewed
May 19, 2023
| """ | ||
|
|
||
| if '.'.join(domain[-3:-1]) != host_domain and use_fail_ns: | ||
| if not domain_not_splited.endswith(host_domain) and use_fail_ns: |
revert last commit
Contributor
Author
|
Idk why git diff is so weird, so I added a review to lines that I changed, other diff indications seems to be IDE linting. |
Contributor
Author
|
the requirements.txt is completely compatible now, it must be in python virtual environment to work, so I added a bash script to run BE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when we use subdomains as registered domain like
dns.domain.comthere is a logical error, i tried to fix it very simply.the reason of using three level domain name is that:
dns.domain.com has a ns record to dnsfookupServerIP.domain.com which any subdomain of *.dns.domain.com will ask their records from dnsfookupServerIP.domain.com, so it is easily possible with this commit to only with having one domain we use dnsfookup as a production/publicly available server