Use better defines for TFT_LVGL_UI: SPI and FSMC version#23
Merged
makerbase-mks merged 1 commit intomakerbase-mks:bugfix-2.0.xfrom Jul 25, 2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
LVGL UI have two versions: SPI (used in Nano v2.0) and FSMC (used in Nano v1.2 and Chitu).
Before this PR, to use the FSMC version, you define
TFT_LVGL_UI, but to use the SPI version, you had to define both:TFT_LVGL_UIandSPI_GRAPHICAL_TFT.It can lead to confusion, because Marlin has other similar define:
FSMC_GRAPHICAL_TFT, the emulated DOGM using FSMC. AndSPI_GRAPHICAL_TFTlooks like its the DOGM, but using SPI...So, I changed the LVGL UI defines to better match with what Marlin follows. Now we have:
I removed references for
SPI_GRAPHICAL_TFT, as in the future we may have a emulated DOGM using SPI, and can use that define when appropriated.Benefits