fix(auth): restore Mustache.escape after rendering OAuth templates#275
Open
beejak wants to merge 1 commit intomakenotion:mainfrom
Open
fix(auth): restore Mustache.escape after rendering OAuth templates#275beejak wants to merge 1 commit intomakenotion:mainfrom
beejak wants to merge 1 commit intomakenotion:mainfrom
Conversation
renderAuthTemplate temporarily set Mustache.escape to the identity function. Restore the previous escape implementation in a finally block so concurrent template rendering and later Mustache uses keep the default HTML-escaping behavior. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enderAuthTemplate\ assigned \Mustache.escape\ to the identity function for URL rendering. If an error occurred after that assignment, or if another request ran concurrently, the global escape function could stay overridden.
Change
Save the previous \Mustache.escape, run URL/body rendering inside \ ry, and restore it in \ inally.
Test plan
pm install --ignore-scripts && npm run build\
Made with Cursor