Fix: Resolve negative seg_level before passing to OpenSlide#321
Open
ItzDEXX wants to merge 1 commit intomahmoodlab:masterfrom
Open
Fix: Resolve negative seg_level before passing to OpenSlide#321ItzDEXX wants to merge 1 commit intomahmoodlab:masterfrom
ItzDEXX wants to merge 1 commit intomahmoodlab:masterfrom
Conversation
OpenSlide's C library doesn't support Python's negative indexing. When seg_level=-1 is passed, read_region returns a black image, causing findContours to return zero contours and hierarchy=None, which crashes at np.squeeze(). This fix converts negative seg_level to the appropriate positive level using get_best_level_for_downsample(64) before any OpenSlide calls.
Author
|
@guillaumejaume @faisalml It would be great if you look into this |
Author
|
Can someone take a look at this ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
OpenSlide's C library doesn't support Python's negative indexing. When
seg_level=-1is passed,read_regionreturns a black image, causingfindContoursto return zero contours andhierarchy=None, which crashes atnp.squeeze().Fix
This fix converts negative
seg_levelto the appropriate positive level usingget_best_level_for_downsample(64)before any OpenSlide calls.