Skip to content

Recover from bad zip files on class-path#67

Open
tslocke wants to merge 1 commit into
magnars:masterfrom
tslocke:patch-1
Open

Recover from bad zip files on class-path#67
tslocke wants to merge 1 commit into
magnars:masterfrom
tslocke:patch-1

Conversation

@tslocke
Copy link
Copy Markdown

@tslocke tslocke commented Nov 7, 2019

Running optimus inside Datomic Ions, I was getting an exception "zip file is empty". With this patch, get-jar-paths returns [] if there is any problem opening the zip file.

If a more focussed catch is preferable, the exception I'm getting is:

#error {:cause "zip file is empty"
        :via [{:type java.util.zip.ZipException, :message "zip file is empty"}]}

Running optimus inside Datomic Ions, I was getting an exception "zip file is empty". With this patch, get-jar-paths returns [] if there is any problem opening the zip file.
@magnars
Copy link
Copy Markdown
Owner

magnars commented Nov 7, 2019

Thanks! What a weird issue. I think we should be more focused in catching this, or it might hide real problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants