fix: regex in transient-init-value to include newlines#433
Open
Zoybean wants to merge 1 commit intomagit:mainfrom
Open
fix: regex in transient-init-value to include newlines#433Zoybean wants to merge 1 commit intomagit:mainfrom
Zoybean wants to merge 1 commit intomagit:mainfrom
Conversation
Member
|
Please format the commit summary like other commit summaries are formatted for in this project, and include the information from the pr description in the commit message. Also include the If you plan to open a pull-request anyway, then you don't have to open a issue first. At least if the change is so small that it wouldn't be a waste of your time, if I ended up rejecting it. |
Allow `transient-init-value' to respect multiline string values, rather than truncating them to the first line. As a regex pattern, ".*" does not match multiline strings because the "." pattern matches any character besides a line terminator. Emacs regex syntax uses the "[^z-a]" pattern to match any character including line terminators. This distinction is represented by `(rx (* nonl))' vs`(rx (* anychar))' in the `rx' macro syntax, and the expression implemented here is as produced by `(rx string-start (literal "%s") (group (* anychar)) string-end)'. Fixes magit#432
Zoybean
force-pushed
the
multiline-init-value
branch
from
c3fd768 to
25fbf25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow
transient-init-valueto respect multiline string values, rather than truncating them to the first line..*does not match multiline strings because the.pattern matches any character besides a line terminator. Emacs regex syntax uses the[^z-a]pattern to match any character including line terminators.Fixes #432