-
Notifications
You must be signed in to change notification settings - Fork 58
Added ScreenConnect event log artifacts. #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
acgabbert
wants to merge
6
commits into
magicsword-io:main
Choose a base branch
from
acgabbert:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1c0099f
Added ScreenConnect event log information and reference.
acgabbert d6c6525
removed unchanged tools
acgabbert 2be0f8b
removed more unneeded files for PR
acgabbert cc9b51e
updated application events for screenconnect
acgabbert 1a0ec3f
updated to single provider name for validation
acgabbert e9e9d28
Update screenconnect.yaml
nasbench File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just FYI the fields aren't standard but are related to the provider, so no "Service Name" for example because that's related to EID 7045.
In this case you need to provide the message that is shown in the event log in the data field or a specific field.
For me to evaluate this i need to see the logs. The blog that you linked in the reference doesn't contain refs to those EIDs. So please if you could provide the data for me to review that would be great.