Implement SSHFP records #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use offset since we may receive a full dns packet Account for maximum hash lengths for each hash type fix: don't use the output of `Buffer#copy()`, instead use `Buffer#byteLength` fix: normalize fingerprint string fix: the offset pointer starts out at RDLENGTH fix: account for the `RDLENGTH` field in `rsshfp.decode()`
martinheidegger
pushed a commit
to dnsquery/dns-packet
that referenced
this pull request
Dec 2, 2022
* Add SSHFP record support Use offset since we may receive a full dns packet Account for maximum hash lengths for each hash type fix: don't use the output of `Buffer#copy()`, instead use `Buffer#byteLength` fix: normalize fingerprint string fix: the offset pointer starts out at RDLENGTH fix: account for the `RDLENGTH` field in `rsshfp.decode()` * tests: add test for the SSHFP record type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.