Skip to content

Add MainThreadBound #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
madsmtm merged 1 commit into from
Jan 18, 2023
Merged

Add MainThreadBound #344

madsmtm merged 1 commit into from
Jan 18, 2023

Conversation

@madsmtm
Copy link
Owner

@madsmtm madsmtm commented Jan 15, 2023 •
edited
Loading

For wrapping types like Id<NSWindow, Shared> which is only safe to access from the main thread.

Should help pushing rust-windowing/winit#2464 forwards.

Previous main thread work: #27

TODO:

  • Proper safety comments
  • The actual implementation for when the thread is not the main thread (basically just dispatch::Queue::main()::exec(|| ...)
  • Figure out relation to Swift's @MainActor

@madsmtm madsmtm added enhancement New feature or request A-framework Affects the framework crates and the translator for them labels Jan 15, 2023
@madsmtm madsmtm marked this pull request as ready for review January 15, 2023 21:40
@madsmtm madsmtm force-pushed the main-thread-bound branch 6 times, most recently from 1fad259 to f78a13a Compare January 15, 2023 22:43
@madsmtm madsmtm merged commit c2fa0ab into master Jan 18, 2023
@madsmtm madsmtm deleted the main-thread-bound branch January 18, 2023 22:33
This was referenced Jan 21, 2023
Merged
Closed
@madsmtm madsmtm added this to the icrate v0.1.0 milestone Jan 27, 2023
madsmtm pushed a commit that referenced this pull request Jan 12, 2026
@MarijnS95
examples: Replace one more unsafe transmute() with trivial `ptr::ca…
3665f50 
…st()` (#351)

Noticed that one more pointer was being transmuted to another type
rather than using a trivial cast, before `unsafe`ly dereferencing it.

This also removes the `ptr::read()` syntax introduced in #344 again,
in favour of using a simple and more standard `*` deref.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-framework Affects the framework crates and the translator for them enhancement New feature or request

Projects

None yet

Milestone

Usable icrate

Development

Successfully merging this pull request may close these issues.

1 participant

@madsmtm