Improve: Add Defensive Parameter Validation to compress2 #1081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request enhances the robustness of the compress2 function by adding defensive checks for its parameters.
Similar to the recent improvements in uncompress2, this function can currently crash with a segmentation fault if passed NULL for its pointer arguments (dest, destLen, source). This change introduces a validation block at the start of the function to guard against this. It also validates the level parameter.
If an invalid parameter is detected, the function now safely returns Z_STREAM_ERROR instead of crashing, providing clear feedback to the developer.
This makes the function safer and more reliable. Happy to receive any feedback.
Thank you!