PR#104
Open
elias-asd8 wants to merge 2 commits intomaazm7d:mainfrom
Open
Conversation
fixed the id and stuff
📝 WalkthroughWalkthroughSix new Termux-oriented desktop and virtualization tool entries (IDs 0153–0158) are added to the metadata tools list, each marked as not requiring root access with a standardized publication date. The existing Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Warning |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
metadata/metadata.json (1)
1831-1833: Inconsistent formatting:repovalue split across two lines."repo": "https://github.com/elias-asd8/Windows-XP-for-termux-via-qemu",This is technically valid JSON, but it is the only entry in the entire file using this layout and most JSON formatters/linters will rewrite it. Keep the key and string value on a single line, matching the other 157 entries.
♻️ Proposed fix
"category": "Virtualization", - "repo": -"https://github.com/elias-asd8/Windows-XP-for-termux-via-qemu", + "repo": "https://github.com/elias-asd8/Windows-XP-for-termux-via-qemu", "author": "elias-asd8",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@metadata/metadata.json` around lines 1831 - 1833, The "repo" key/value pair is split across two lines for the entry with category "Virtualization"; update that JSON object so the "repo" key and its URL value are on a single line (e.g., change the fragmented `"repo":` and `"https://github.com/elias-asd8/Windows-XP-for-termux-via-qemu",` into a single-line `"repo": "https://github.com/elias-asd8/Windows-XP-for-termux-via-qemu",`) to match the formatting of the other entries and keep JSON style consistent.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@metadata/metadata.json`:
- Around line 1827-1887: The six new metadata entries (id "0153" Windows XP for
Termux, "0154" Windows 7 VM, "0155" GNOME Vibes, "0156" Kali VM, "0157" Arch KDE
Plasma, "0158" DE Installer (Rootless)) are missing the required install
instructions and the optional-but-consistent "thumbnail" key; open each object
in metadata.json (locate by the id or name fields) and add an "install" string
populated with the repository's setup/install command sequence copied from that
repo's README (e.g., git clone … && bash setup.sh or the repo-specific commands)
and add "thumbnail": "" to match other entries so the UI shows actionable
install steps and consistent metadata.
- Around line 1825-1889: The JSON has two structural errors: remove the trailing
comma after the "publishedAt" property in the earlier tool object (the dangling
comma immediately before that object's closing brace) and delete the extra stray
closing brace that appears after the final tool object (the object with "id":
"0158") so the tools array closes correctly; after those two edits the JSON will
be balanced and parseable for MetadataDto deserialization.
---
Nitpick comments:
In `@metadata/metadata.json`:
- Around line 1831-1833: The "repo" key/value pair is split across two lines for
the entry with category "Virtualization"; update that JSON object so the "repo"
key and its URL value are on a single line (e.g., change the fragmented
`"repo":` and `"https://github.com/elias-asd8/Windows-XP-for-termux-via-qemu",`
into a single-line `"repo":
"https://github.com/elias-asd8/Windows-XP-for-termux-via-qemu",`) to match the
formatting of the other entries and keep JSON style consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Comment on lines
+1825
to
1889
| "publishedAt": "25-03-2026", | ||
| }, | ||
| { | ||
| "id": "0153", | ||
| "name": "Windows XP for Termux", | ||
| "description": "A Windows XP VM for Termux via QEMU.", | ||
| "category": "Virtualization", | ||
| "repo": | ||
| "https://github.com/elias-asd8/Windows-XP-for-termux-via-qemu", | ||
| "author": "elias-asd8", | ||
| "requireRoot": false, | ||
| "publishedAt": "25-04-2026" | ||
| }, | ||
| { | ||
| "id": "0154", | ||
| "name": "Windows 7 VM", | ||
| "description": "Windows 7 Virtual Machine setup for Termux.", | ||
| "category": "Virtualization", | ||
| "repo": "https://github.com/elias-asd8/Windows-7-VM-for-Termux", | ||
| "author": "elias-asd8", | ||
| "requireRoot": false, | ||
| "publishedAt": "25-04-2026" | ||
| }, | ||
| { | ||
| "id": "0155", | ||
| "name": "GNOME Vibes", | ||
| "description": "GNOME-like desktop experience without full GNOME.", | ||
| "category": "Desktop", | ||
| "repo": "https://github.com/elias-asd8/GNOME-vibes-without-GNOME-Termux", | ||
| "author": "elias-asd8", | ||
| "requireRoot": false, | ||
| "publishedAt": "25-04-2026" | ||
| }, | ||
| { | ||
| "id": "0156", | ||
| "name": "Kali VM", | ||
| "description": "Kali Linux Virtual Machine for Termux environment.", | ||
| "category": "Virtualization", | ||
| "repo": "https://github.com/elias-asd8/Kali-VM-for-Termux", | ||
| "author": "elias-asd8", | ||
| "requireRoot": false, | ||
| "publishedAt": "25-04-2026" | ||
| }, | ||
| { | ||
| "id": "0157", | ||
| "name": "Arch KDE Plasma", | ||
| "description": "KDE Plasma desktop on Arch Linux ARM.", | ||
| "category": "Desktop", | ||
| "repo": "https://github.com/elias-asd8/Arch-Termux-KDE-Plasma", | ||
| "author": "elias-asd8", | ||
| "requireRoot": false, | ||
| "publishedAt": "25-04-2026" | ||
| }, | ||
| { | ||
| "id": "0158", | ||
| "name": "DE Installer (Rootless)", | ||
| "description": "Install Desktop Environments in Termux without root.", | ||
| "category": "Script", | ||
| "repo": "https://github.com/elias-asd8/DE-Installer-for-Termux-without-root", | ||
| "author": "elias-asd8", | ||
| "requireRoot": false, | ||
| "publishedAt": "25-04-2026" | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
Invalid JSON: trailing comma and stray closing brace will break metadata parsing.
Two structural defects make this file fail to parse, which will break MetadataDto deserialization and effectively wipe out the entire tools list in the app:
- Line 1825: a trailing comma was added after
"publishedAt": "25-03-2026"inside thebastetobject (now followed by}on line 1826). JSON does not permit trailing commas. This is exactly what Biome reports at line 1826:Expected a property but instead found '}'. - Lines 1888–1889: there is an extra
}between the last tool object's closing brace (line 1887) and the]that closes thetoolsarray (line 1890), making the document unbalanced.
🐛 Proposed fix
"requireRoot": false,
- "publishedAt": "25-03-2026",
+ "publishedAt": "25-03-2026"
},
{
"id": "0153", "requireRoot": false,
"publishedAt": "25-04-2026"
- }
-
- }
+ }
]
}🧰 Tools
🪛 Biome (2.4.13)
[error] 1826-1826: Expected a property but instead found '}'.
(parse)
[error] 1889-1889: expected , but instead found }
(parse)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@metadata/metadata.json` around lines 1825 - 1889, The JSON has two structural
errors: remove the trailing comma after the "publishedAt" property in the
earlier tool object (the dangling comma immediately before that object's closing
brace) and delete the extra stray closing brace that appears after the final
tool object (the object with "id": "0158") so the tools array closes correctly;
after those two edits the JSON will be balanced and parseable for MetadataDto
deserialization.
Comment on lines
+1827
to
+1887
| { | ||
| "id": "0153", | ||
| "name": "Windows XP for Termux", | ||
| "description": "A Windows XP VM for Termux via QEMU.", | ||
| "category": "Virtualization", | ||
| "repo": | ||
| "https://github.com/elias-asd8/Windows-XP-for-termux-via-qemu", | ||
| "author": "elias-asd8", | ||
| "requireRoot": false, | ||
| "publishedAt": "25-04-2026" | ||
| }, | ||
| { | ||
| "id": "0154", | ||
| "name": "Windows 7 VM", | ||
| "description": "Windows 7 Virtual Machine setup for Termux.", | ||
| "category": "Virtualization", | ||
| "repo": "https://github.com/elias-asd8/Windows-7-VM-for-Termux", | ||
| "author": "elias-asd8", | ||
| "requireRoot": false, | ||
| "publishedAt": "25-04-2026" | ||
| }, | ||
| { | ||
| "id": "0155", | ||
| "name": "GNOME Vibes", | ||
| "description": "GNOME-like desktop experience without full GNOME.", | ||
| "category": "Desktop", | ||
| "repo": "https://github.com/elias-asd8/GNOME-vibes-without-GNOME-Termux", | ||
| "author": "elias-asd8", | ||
| "requireRoot": false, | ||
| "publishedAt": "25-04-2026" | ||
| }, | ||
| { | ||
| "id": "0156", | ||
| "name": "Kali VM", | ||
| "description": "Kali Linux Virtual Machine for Termux environment.", | ||
| "category": "Virtualization", | ||
| "repo": "https://github.com/elias-asd8/Kali-VM-for-Termux", | ||
| "author": "elias-asd8", | ||
| "requireRoot": false, | ||
| "publishedAt": "25-04-2026" | ||
| }, | ||
| { | ||
| "id": "0157", | ||
| "name": "Arch KDE Plasma", | ||
| "description": "KDE Plasma desktop on Arch Linux ARM.", | ||
| "category": "Desktop", | ||
| "repo": "https://github.com/elias-asd8/Arch-Termux-KDE-Plasma", | ||
| "author": "elias-asd8", | ||
| "requireRoot": false, | ||
| "publishedAt": "25-04-2026" | ||
| }, | ||
| { | ||
| "id": "0158", | ||
| "name": "DE Installer (Rootless)", | ||
| "description": "Install Desktop Environments in Termux without root.", | ||
| "category": "Script", | ||
| "repo": "https://github.com/elias-asd8/DE-Installer-for-Termux-without-root", | ||
| "author": "elias-asd8", | ||
| "requireRoot": false, | ||
| "publishedAt": "25-04-2026" | ||
| } |
There was a problem hiding this comment.
Missing install field on all six new entries.
Every other entry in this file specifies an install script (e.g. git clone … && bash setup.sh), and the app surfaces these instructions to users. The new entries 0153–0158 omit install entirely. While ToolDto.install is nullable with a "" default (so deserialization will not fail once the JSON syntax is fixed), users will see empty install instructions and the tools will be effectively non-actionable.
Please add an install field for each of the six entries with the correct setup commands from each repository's README. Also consider adding "thumbnail": "" for consistency with every other entry.
Want me to draft install blocks based on each linked repo's README?
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@metadata/metadata.json` around lines 1827 - 1887, The six new metadata
entries (id "0153" Windows XP for Termux, "0154" Windows 7 VM, "0155" GNOME
Vibes, "0156" Kali VM, "0157" Arch KDE Plasma, "0158" DE Installer (Rootless))
are missing the required install instructions and the optional-but-consistent
"thumbnail" key; open each object in metadata.json (locate by the id or name
fields) and add an "install" string populated with the repository's
setup/install command sequence copied from that repo's README (e.g., git clone …
&& bash setup.sh or the repo-specific commands) and add "thumbnail": "" to match
other entries so the UI shows actionable install steps and consistent metadata.
Owner
|
You didn’t follow the contribution guidelines at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit