refactor: move component config info to attribute #984

PupilTong · 2025-06-03T09:38:46Z

No description provided.

changeset-bot · 2025-06-03T09:38:51Z

🦋 Changeset detected

Latest commit: 486c3da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
@lynx-js/web-mainthread-apis	Patch
@lynx-js/web-constants	Patch
@lynx-js/web-core	Patch
@lynx-js/web-core-server	Patch
@lynx-js/web-worker-runtime	Patch
@lynx-js/web-worker-rpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot

Pull Request Overview

This PR refactors how component configuration is managed by moving the config from an in-memory runtime object to a DOM attribute. Key changes include removing the componentConfig field from the runtime object, updating attribute and property functions to read and write JSON data on a new attribute, and adjusting type imports accordingly.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
packages/web-platform/web-mainthread-apis/src/elementAPI/elementCreating/elementCreatingFunctions.ts	Removed componentConfig from runtime config
packages/web-platform/web-mainthread-apis/src/elementAPI/attributeAndProperty/attributeAndPropertyFunctions.ts	Refactored component config access to use element attributes instead of runtime storage
packages/web-platform/web-mainthread-apis/src/elementAPI/ElementThreadElement.ts	Removed componentConfig type reference
packages/web-platform/web-constants/src/constants.ts	Added lynxComponentConfigAttribute constant
.changeset/eight-ghosts-shake.md	Updated changeset for patch version

...orm/web-mainthread-apis/src/elementAPI/attributeAndProperty/attributeAndPropertyFunctions.ts

codspeed-hq · 2025-06-03T09:53:18Z

CodSpeed Performance Report

Merging #984 will not alter performance

_{Comparing PupilTong:p/hw/component-config (486c3da) with main (0525fbf)}

Summary

✅ 9 untouched benchmarks

relativeci · 2025-06-03T09:59:48Z

Web Explorer

#1118 Bundle Size — 254.5KiB (+0.06%).

486c3da(current) vs 0525fbf main#1112(baseline)

Bundle metrics

3 changes

1 regression

	Current #1118	Baseline #1112
Initial JS	`136.63KiB`(`+0.02%`)	`136.61KiB`
Initial CSS	`31.79KiB`	`31.79KiB`
Cache Invalidation	`87.5%`	`87.49%`
Chunks	`4`	`4`
Assets	`4`	`4`
Modules	`202`	`202`
Duplicate Modules	`14`	`14`
Duplicate Code	`2.87%`(`+0.35%`)	`2.86%`
Packages	`4`	`4`
Duplicate Packages	`0`	`0`

Bundle size by type

1 change

1 regression

	Current #1118	Baseline #1112
JS	`222.71KiB` (`+0.07%`)	`222.57KiB`
CSS	`31.79KiB`	`31.79KiB`

Bundle analysis report Branch PupilTong:p/hw/component-config Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2025-06-03T09:59:48Z

React Example

#1130 Bundle Size — 231.7KiB (0%).

486c3da(current) vs 0525fbf main#1124(baseline)

Bundle metrics no changes

	Current #1130	Baseline #1124
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`4`	`4`
Modules	`141`	`141`
Duplicate Modules	`56`	`56`
Duplicate Code	`46.17%`	`46.17%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #1130	Baseline #1124
IMG	`145.76KiB`	`145.76KiB`
Other	`85.94KiB`	`85.94KiB`

Bundle analysis report Branch PupilTong:p/hw/component-config Project dashboard

^{Generated by RelativeCI Documentation Report issue}

@deprecated

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @lynx-js/[email protected] ### Patch Changes - Support for locating errors in the source code directly on the device when exceptions occur when using MTS. ([#1019](#1019)) This requires Lynx engine v3.4 or later. - Fix the "main-thread.js exception: ReferenceError: `__webpack_require__` is not defined" error in HMR. ([#985](#985)) This error occurred when setting `output.iife: true`, which is the default value in `@lynx-js/rspeedy` v0.9.8. ## @lynx-js/[email protected] ### Patch Changes - Set `optimization.emitOnErrors` when `DEBUG` is enabled. ([#1000](#1000)) This is useful for debugging PrimJS Syntax error. ## @lynx-js/[email protected] ### Patch Changes - Better [zustand](https://github.com/pmndrs/zustand) support by creating an alias for `use-sync-external-store`. ([#980](#980)) See [#893](#893) for more details. - Updated dependencies \[[`acc0d80`](acc0d80)]: - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - Support Windows. ([#1007](#1007)) ## @lynx-js/[email protected] ### Patch Changes - feat: add sheet.insertRule support ([#1026](#1026)) - refactor: implement mts apis in closure pattern ([#1004](#1004)) ## @lynx-js/[email protected] ### Patch Changes - refactor: move some internal status to dom's attribute ([#945](#945)) It's essential for SSR - fix: target.id is undefined ([#1016](#1016)) - feat: add new pageConfig configuration: enableJSDataProcessor ([#886](#886)) - refactor: move component config info to attribute ([#984](#984)) - refactor: save dataset on an attribute ([#981](#981)) On lynx, the `data-*` attributes have different behaviors than the HTMLElement has. The dataset will be treated as properties, the key will not be applied the camel-case <-> hyphenate name transformation. Before this commit we use it as a runtime data, but after this commit we will use encodeURI(JSON.stringify(dataset)) to encode it as a string. - refactor: create elements of `elementToRuntimeInfoMap` on demand ([#986](#986)) - refactor: implement mts apis in closure pattern ([#1004](#1004)) - Updated dependencies \[]: - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - refactor: move some internal status to dom's attribute ([#945](#945)) It's essential for SSR - refactor: avoid to create many style element for cssog ([#1026](#1026)) - refactor: move component config info to attribute ([#984](#984)) - fix: ensure render starts after dom connected ([#1020](#1020)) - refactor: save dataset on an attribute ([#981](#981)) On lynx, the `data-*` attributes have different behaviors than the HTMLElement has. The dataset will be treated as properties, the key will not be applied the camel-case <-> hyphenate name transformation. Before this commit we use it as a runtime data, but after this commit we will use encodeURI(JSON.stringify(dataset)) to encode it as a string. - refactor: implement mts apis in closure pattern ([#1004](#1004)) - Updated dependencies \[[`70b82d2`](70b82d2), [`5651e24`](5651e24), [`9499ea9`](9499ea9), [`50f0193`](50f0193), [`57bf0ef`](57bf0ef), [`5651e24`](5651e24), [`0525fbf`](0525fbf), [`b6b87fd`](b6b87fd), [`c014327`](c014327)]: - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - refactor: move some internal status to dom's attribute ([#945](#945)) It's essential for SSR - refactor: move component config info to attribute ([#984](#984)) - refactor: save dataset on an attribute ([#981](#981)) On lynx, the `data-*` attributes have different behaviors than the HTMLElement has. The dataset will be treated as properties, the key will not be applied the camel-case <-> hyphenate name transformation. Before this commit we use it as a runtime data, but after this commit we will use encodeURI(JSON.stringify(dataset)) to encode it as a string. - fix: dump encode data in comment ([#989](#989)) ## @lynx-js/[email protected] ### Patch Changes - feat: x-input && x-textarea add new method: `getValue`, which returns the value of the input element, selectionStart and selectEnd when success. ([#982](#982)) - feat: x-input and x-textarea bindinput event return structures add `selectionStart`, `selectionEnd`, and `textLength`, `textLength` are marked as @deprecated ([#996](#996)) - feat: x-input and x-textarea support bindselection event, the returned type structure is `{ selectionStart: number; selectionEnd: number }`. ([#990](#990)) - Updated dependencies \[]: - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - refactor: move some internal status to dom's attribute ([#945](#945)) It's essential for SSR - refactor: avoid to create many style element for cssog ([#1026](#1026)) - fix: target.id is undefined ([#1016](#1016)) - feat: add new pageConfig configuration: enableJSDataProcessor ([#886](#886)) - refactor: move component config info to attribute ([#984](#984)) - refactor: save dataset on an attribute ([#981](#981)) On lynx, the `data-*` attributes have different behaviors than the HTMLElement has. The dataset will be treated as properties, the key will not be applied the camel-case <-> hyphenate name transformation. Before this commit we use it as a runtime data, but after this commit we will use encodeURI(JSON.stringify(dataset)) to encode it as a string. - refactor: create elements of `elementToRuntimeInfoMap` on demand ([#986](#986)) - refactor: implement mts apis in closure pattern ([#1004](#1004)) - Updated dependencies \[[`70b82d2`](70b82d2), [`9499ea9`](9499ea9), [`50f0193`](50f0193), [`57bf0ef`](57bf0ef), [`0525fbf`](0525fbf), [`b6b87fd`](b6b87fd), [`c014327`](c014327)]: - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - refactor: implement mts apis in closure pattern ([#1004](#1004)) - Updated dependencies \[[`70b82d2`](70b82d2), [`5651e24`](5651e24), [`9499ea9`](9499ea9), [`50f0193`](50f0193), [`57bf0ef`](57bf0ef), [`5651e24`](5651e24), [`0525fbf`](0525fbf), [`b6b87fd`](b6b87fd), [`c014327`](c014327)]: - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - Fix `requestAnimationFrame` is not working. ([#1021](#1021)) ## @lynx-js/[email protected] ### Patch Changes - Updated dependencies \[[`ccb4254`](ccb4254)]: - @lynx-js/[email protected] ## [email protected] ## @lynx-js/[email protected] ## [email protected] ## @lynx-js/[email protected] ## @lynx-js/[email protected] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

refactor: move component config info to attribute

486c3da

PupilTong requested a review from Copilot June 3, 2025 09:38

PupilTong self-assigned this Jun 3, 2025

PupilTong added this to Lynx for Web Jun 3, 2025

PupilTong added the platform:Web label Jun 3, 2025

Copilot AI reviewed Jun 3, 2025

View reviewed changes

...orm/web-mainthread-apis/src/elementAPI/attributeAndProperty/attributeAndPropertyFunctions.ts Show resolved Hide resolved

...orm/web-mainthread-apis/src/elementAPI/attributeAndProperty/attributeAndPropertyFunctions.ts Show resolved Hide resolved

PupilTong requested a review from Sherry-hue June 3, 2025 10:55

Sherry-hue approved these changes Jun 3, 2025

View reviewed changes

Sherry-hue added this pull request to the merge queue Jun 3, 2025

Merged via the queue into lynx-family:main with commit 57bf0ef Jun 3, 2025
40 checks passed

github-project-automation bot moved this to Done in Lynx for Web Jun 3, 2025

github-actions bot mentioned this pull request Jun 3, 2025

chore: Release 2025-06-06 12:15:14 #979

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: move component config info to attribute #984

refactor: move component config info to attribute #984

Uh oh!

PupilTong commented Jun 3, 2025

Uh oh!

changeset-bot bot commented Jun 3, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Jun 3, 2025

Uh oh!

relativeci bot commented Jun 3, 2025

Uh oh!

relativeci bot commented Jun 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

refactor: move component config info to attribute #984

refactor: move component config info to attribute #984

Uh oh!

Conversation

PupilTong commented Jun 3, 2025

Uh oh!

changeset-bot bot commented Jun 3, 2025

🦋 Changeset detected

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Jun 3, 2025

CodSpeed Performance Report

Merging #984 will not alter performance

Summary

Uh oh!

relativeci bot commented Jun 3, 2025

Web Explorer

#1118 Bundle Size — 254.5KiB (+0.06%).

Uh oh!

relativeci bot commented Jun 3, 2025

React Example

#1130 Bundle Size — 231.7KiB (0%).

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants