Skip to content

fixes #322 check for null#336

Merged
mre merged 2 commits into
lycheeverse:masterfrom
Arteiii:patch-1
May 12, 2026
Merged

fixes #322 check for null#336
mre merged 2 commits into
lycheeverse:masterfrom
Arteiii:patch-1

Conversation

@Arteiii

@Arteiii Arteiii commented May 5, 2026

Copy link
Copy Markdown
Collaborator

fixes #322

ig the main issue was an api issue checking for null should work fine otherwise we can add semver validation via regex

fixes lycheeverse#322 

ig the main issue was an api issue checking for null should work fine
otherwise we can add semver validation via regex
@Arteiii Arteiii self-assigned this May 5, 2026
@Arteiii Arteiii added the bug Something isn't working label May 5, 2026
Comment thread .github/workflows/lychee-version.yml Outdated
Comment thread .github/workflows/lychee-version.yml
Comment thread .github/workflows/lychee-version.yml
@mre

mre commented May 8, 2026

Copy link
Copy Markdown
Member

To make this bulletproof, we can tell curl to treat HTTP errors (like 403 or 404) as actual failures using the -f (or --fail) flag, and show errors with -S (or --show-error):

release=$(curl -sSf https://api.github.com/repos/lycheeverse/lychee/releases/latest | jq -r .tag_name)

With -sSf, if GitHub returns a 403, curl will exit with a failure code, triggering the pipeline's pipefail and stopping the script immediately.

This could be in addition to your check.

@mre

mre commented May 12, 2026

Copy link
Copy Markdown
Member

Perfect. 👌

@mre mre merged commit a63497c into lycheeverse:master May 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix "Update lycheeVersion to null"

2 participants