Skip to content

Fix lychee version check#288

Merged
mre merged 1 commit intolycheeverse:masterfrom
mondeja:fix-lychee-version-check
May 8, 2025
Merged

Fix lychee version check#288
mre merged 1 commit intolycheeverse:masterfrom
mondeja:fix-lychee-version-check

Conversation

@mondeja
Copy link
Contributor

@mondeja mondeja commented Apr 20, 2025

A change introduced in #279 triggers a weird error message. Check https://github.com/simple-icons/simple-icons/actions/runs/14554296040/job/40829177263#step:13:84

The problems are two as I can see:

  • lychee --version | head -n1 | cut -d" " -f4 returns an empty string. It should be -f2 as the output of lychee --version is lychee <version>
  • Semver comparisons are not possible using -lt in Bash. That raises an integer expression expected.

@mre
Copy link
Member

mre commented May 8, 2025

Thanks for the fix @mondeja. ✌️

@mre mre merged commit 82202e5 into lycheeverse:master May 8, 2025
4 checks passed
@mondeja mondeja deleted the fix-lychee-version-check branch May 8, 2025 21:06
@mre
Copy link
Member

mre commented May 21, 2025

@MrG9090, approvals on pull requests, please. It creates noise in the form of GitHub notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants