Update README.md to include continue-on-error: true in action#267
Merged
mre merged 2 commits intolycheeverse:masterfrom Nov 19, 2024
Merged
Update README.md to include continue-on-error: true in action#267mre merged 2 commits intolycheeverse:masterfrom
mre merged 2 commits intolycheeverse:masterfrom
Conversation
Member
|
Yeah, I think that makes sense. @YDX-2147483647, right? |
Contributor
|
I agree that the example in the README does not work, but I suggest adding lychee-action/.github/workflows/links.yml Lines 17 to 22 in 5cd5ba7 - name: Link Checker
id: lychee
uses: lycheeverse/lychee-action@v2
+ with:
+ fail: falseIf lychee is properly configured, I actually use |
mre
reviewed
Nov 9, 2024
Member
|
Thanks for your contribution @psobolewskiPhD. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to add
in order for the next step to fire when there were broken links -- regardless of the
if:I tested with adding a Debug echo step after the lychee step.
And this was skipped.