secure-socket: fix #341 and refactor biowrap #343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #341
Implements the same fix described in the issue #341, and refactors the whole biowrap code. Should be now slightly cleaner so I don't have to spend 4 days debugging something like this again (hopefully).
testing
key changes
Also added the TODOs I could think of as I was browsing the code, hopefully I will implement those later on, most importantly we handle none of the shutdowns right now.
questions
I am not entirely sure if the timer solution is perfect, we can't use a normal coroutine, so the only way I could think of to defer this callback is a timer, I assume I also don't have to manually close the timer handle after it finishes?