HTTPS support #310
Open
HTTPS support #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I've tested with a certificate, it partially works since sometimes it hangs. |
Contributor
|
The hang outs may have been caused by the issue described in #329, I remember debugging this extensively and not figuring it out. Can you give this another test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assume that this should bring HTTPS support into
createServer. Maybe going one step further with justoptions?After quick testing, coro-net works with this change (I have no certificate yet to test with, but from the error I assume that it will work with the certificate, setting
tlstofalseor_,will avoid this error, at least it worked for me):/root/Luvit/deps/coro-net.lua:80: TLS servers require a certificate