Skip to content

SuperNova: Fix ROM test and remove dead code#127

Merged
adr1anh merged 3 commits intolurk-lang:devfrom
adr1anh:ah/sn_fix_test
Nov 21, 2023
Merged

SuperNova: Fix ROM test and remove dead code#127
adr1anh merged 3 commits intolurk-lang:devfrom
adr1anh:ah/sn_fix_test

Conversation

@adr1anh
Copy link
Copy Markdown
Contributor

@adr1anh adr1anh commented Nov 16, 2023

The ROM test was broken and not actually doing what it was supposed to.
In particular:

  • The input rom_index was initialized with the first opcode, rather than 0
  • SquareCircuit::synthesize was checking the next opcode twice
  • constrain_augmented_circuit_index was not checking what it was supposed to.

This issue was found while trying to remove dead code in PR #120.

@adr1anh adr1anh marked this pull request as ready for review November 16, 2023 20:35
@adr1anh adr1anh requested a review from porcuquine November 16, 2023 20:35
@porcuquine
Copy link
Copy Markdown
Contributor

porcuquine commented Nov 17, 2023

Let's merge #120 then rebase this to simplify review, please.

@adr1anh
Copy link
Copy Markdown
Contributor Author

adr1anh commented Nov 17, 2023

Let's merge #120 then rebase this to simplify review, please.

Done, the changes are much smaller now.

porcuquine
porcuquine reviewed Nov 20, 2023
View reviewed changes
src/supernova/test.rs Outdated
Comment on lines +419 to +420
let circuit_primary = test_rom.primary_circuit(op_code);
let circuit_secondary = test_rom.secondary_circuit();
Copy link
Copy Markdown
Contributor

@porcuquine porcuquine Nov 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move these bindings to the top of the loop and use them in the binding of recursive_snark also.

Copy link
Copy Markdown
Contributor Author

@adr1anh adr1anh Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

porcuquine
porcuquine previously approved these changes Nov 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@porcuquine porcuquine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine. Independent of bug fixes, I agree that simplifying the logic of this test example is useful. I think it exists in its current form for historical reasons, and there is little value in preserving the specific 'ROM' use case beyond the extent to which it also serves as a clear test and example. These changes seem to bring it closer to serving that purpose.

huitseeker
huitseeker previously approved these changes Nov 20, 2023
View reviewed changes
src/supernova/test.rs
}
}
/// c = a + b where a, b is `AllocatedNum`
pub fn add_allocated_num<F: PrimeField, CS: ConstraintSystem<F>>(
Copy link
Copy Markdown
Contributor

@huitseeker huitseeker Nov 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case this comes up one day, https://github.com/lurk-lab/bellpepper/blob/main/crates/bellpepper-core/src/gadgets/num.rs#L279-L309

@adr1anh adr1anh dismissed stale reviews from huitseeker and porcuquine via fbebbec November 21, 2023 11:44
@adr1anh adr1anh enabled auto-merge November 21, 2023 11:45
@adr1anh adr1anh added this pull request to the merge queue Nov 21, 2023
Merged via the queue into lurk-lang:dev with commit 753fe39 Nov 21, 2023
@adr1anh adr1anh deleted the ah/sn_fix_test branch November 21, 2023 16:46
huitseeker added a commit that referenced this pull request Dec 17, 2023
@huitseeker @wyattbenno777
@winston-h-zhang @hero78119 @porcuquine @samuelburnham @mpenciak @adr1anh
supernova
c89793e 
This backports the following Arecibo PRs:
- #2
- #3
- #10
- #16
- #23
- #30
- #28
- #41
- #45
- #50
- #56
- #51
- #72
- #92
- #95
- #97
- #101
- #110
- #106
- #112
- #114
- #119
- #120
- #127
- #123
- #131
- #174
- #175
- #182

Co-authored-by: WYATT <wyattbenno@gmail.com>
Co-authored-by: Hanting Zhang <hantingz@usc.edu>
Co-authored-by: Ming <hero78119@gmail.com>
Co-authored-by: porcuquine <porcuquine@users.noreply.github.com>
Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com>
Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com>
Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>
huitseeker added a commit to lurk-lang/Nova that referenced this pull request Dec 17, 2023
@huitseeker @wyattbenno777
@winston-h-zhang @hero78119 @porcuquine @samuelburnham @mpenciak @adr1anh
feat: implement SuperNova
7ec769d 
This implements [Supernova](https://eprint.iacr.org/2022/1758), allowing:
- a 'pay-as-you-go' cost structure for folding operations, through the SuperNova folding scheme,
- a final SNARK that efficiently compresses an instance of this folded proof, through batching techniques.

References:
- the [blog post](https://blog.lurk-lang.org/posts/arecibo-supernova/#technical-release-note-supernova-protocol-integration-into-nova) goes into our construction,
  and links to two more specialized notes on [the `CompressedSNARK` for Supernova](https://hackmd.io/@adr1anh/BJw1g0aBT) along with our variant of the [public input padding issue](https://hackmd.io/@adr1anh/Sy08YaVBa).
- the Readme at `src/supernova/Readme.md`

This backports the following Arecibo PRs:
- lurk-lang/arecibo#2
- lurk-lang/arecibo#3
- lurk-lang/arecibo#10
- lurk-lang/arecibo#16
- lurk-lang/arecibo#23
- lurk-lang/arecibo#30
- lurk-lang/arecibo#28
- lurk-lang/arecibo#41
- lurk-lang/arecibo#45
- lurk-lang/arecibo#50
- lurk-lang/arecibo#56
- lurk-lang/arecibo#51
- lurk-lang/arecibo#72
- lurk-lang/arecibo#92
- lurk-lang/arecibo#95
- lurk-lang/arecibo#97
- lurk-lang/arecibo#101
- lurk-lang/arecibo#110
- lurk-lang/arecibo#106
- lurk-lang/arecibo#112
- lurk-lang/arecibo#114
- lurk-lang/arecibo#119
- lurk-lang/arecibo#120
- lurk-lang/arecibo#127
- lurk-lang/arecibo#123
- lurk-lang/arecibo#131
- lurk-lang/arecibo#174
- lurk-lang/arecibo#175
- lurk-lang/arecibo#182

Co-authored-by: WYATT <wyattbenno@gmail.com>
Co-authored-by: Hanting Zhang <hantingz@usc.edu>
Co-authored-by: Ming <hero78119@gmail.com>
Co-authored-by: porcuquine <porcuquine@users.noreply.github.com>
Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com>
Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com>
Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>
huitseeker added a commit to lurk-lang/Nova that referenced this pull request Dec 18, 2023
@huitseeker @wyattbenno777
@winston-h-zhang @hero78119 @porcuquine @samuelburnham @mpenciak @adr1anh
feat: implement SuperNova
b56a3eb 
This implements [Supernova](https://eprint.iacr.org/2022/1758), allowing:
- a 'pay-as-you-go' cost structure for folding operations, through the SuperNova folding scheme,
- a final SNARK that efficiently compresses an instance of this folded proof, through batching techniques.

References:
- the [blog post](https://blog.lurk-lang.org/posts/arecibo-supernova/#technical-release-note-supernova-protocol-integration-into-nova) goes into our construction,
  and links to two more specialized notes on [the `CompressedSNARK` for Supernova](https://hackmd.io/@adr1anh/BJw1g0aBT) along with our variant of the [public input padding issue](https://hackmd.io/@adr1anh/Sy08YaVBa).
- the Readme at `src/supernova/Readme.md`

This backports the following Arecibo PRs:
- lurk-lang/arecibo#2
- lurk-lang/arecibo#3
- lurk-lang/arecibo#10
- lurk-lang/arecibo#16
- lurk-lang/arecibo#23
- lurk-lang/arecibo#30
- lurk-lang/arecibo#28
- lurk-lang/arecibo#41
- lurk-lang/arecibo#45
- lurk-lang/arecibo#50
- lurk-lang/arecibo#56
- lurk-lang/arecibo#51
- lurk-lang/arecibo#72
- lurk-lang/arecibo#92
- lurk-lang/arecibo#95
- lurk-lang/arecibo#97
- lurk-lang/arecibo#101
- lurk-lang/arecibo#110
- lurk-lang/arecibo#106
- lurk-lang/arecibo#112
- lurk-lang/arecibo#114
- lurk-lang/arecibo#119
- lurk-lang/arecibo#120
- lurk-lang/arecibo#127
- lurk-lang/arecibo#123
- lurk-lang/arecibo#131
- lurk-lang/arecibo#174
- lurk-lang/arecibo#175
- lurk-lang/arecibo#182

Co-authored-by: WYATT <wyattbenno@gmail.com>
Co-authored-by: Hanting Zhang <hantingz@usc.edu>
Co-authored-by: Ming <hero78119@gmail.com>
Co-authored-by: porcuquine <porcuquine@users.noreply.github.com>
Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com>
Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com>
Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>
@huitseeker huitseeker mentioned this pull request Dec 18, 2023
Open
huitseeker added a commit to lurk-lang/Nova that referenced this pull request Jan 3, 2024
@huitseeker @wyattbenno777
@winston-h-zhang @hero78119 @porcuquine @samuelburnham @mpenciak @adr1anh
feat: implement SuperNova
11d271b 
This implements [Supernova](https://eprint.iacr.org/2022/1758), allowing:
- a 'pay-as-you-go' cost structure for folding operations, through the SuperNova folding scheme,
- a final SNARK that efficiently compresses an instance of this folded proof, through batching techniques.

References:
- the [blog post](https://blog.lurk-lang.org/posts/arecibo-supernova/#technical-release-note-supernova-protocol-integration-into-nova) goes into our construction,
  and links to two more specialized notes on [the `CompressedSNARK` for Supernova](https://hackmd.io/@adr1anh/BJw1g0aBT) along with our variant of the [public input padding issue](https://hackmd.io/@adr1anh/Sy08YaVBa).
- the Readme at `src/supernova/Readme.md`

This backports the following Arecibo PRs:
- lurk-lang/arecibo#2
- lurk-lang/arecibo#3
- lurk-lang/arecibo#10
- lurk-lang/arecibo#16
- lurk-lang/arecibo#23
- lurk-lang/arecibo#30
- lurk-lang/arecibo#28
- lurk-lang/arecibo#41
- lurk-lang/arecibo#45
- lurk-lang/arecibo#50
- lurk-lang/arecibo#56
- lurk-lang/arecibo#51
- lurk-lang/arecibo#72
- lurk-lang/arecibo#92
- lurk-lang/arecibo#95
- lurk-lang/arecibo#97
- lurk-lang/arecibo#101
- lurk-lang/arecibo#110
- lurk-lang/arecibo#106
- lurk-lang/arecibo#112
- lurk-lang/arecibo#114
- lurk-lang/arecibo#119
- lurk-lang/arecibo#120
- lurk-lang/arecibo#127
- lurk-lang/arecibo#123
- lurk-lang/arecibo#131
- lurk-lang/arecibo#174
- lurk-lang/arecibo#175
- lurk-lang/arecibo#182

Co-authored-by: WYATT <wyattbenno@gmail.com>
Co-authored-by: Hanting Zhang <hantingz@usc.edu>
Co-authored-by: Ming <hero78119@gmail.com>
Co-authored-by: porcuquine <porcuquine@users.noreply.github.com>
Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com>
Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com>
Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>
huitseeker added a commit to lurk-lang/Nova that referenced this pull request Jan 4, 2024
@huitseeker @wyattbenno777
@winston-h-zhang @hero78119 @porcuquine @samuelburnham @mpenciak @adr1anh
feat: implement SuperNova
fb936b1 
This implements [Supernova](https://eprint.iacr.org/2022/1758), allowing:
- a 'pay-as-you-go' cost structure for folding operations, through the SuperNova folding scheme,
- a final SNARK that efficiently compresses an instance of this folded proof, through batching techniques.

References:
- the [blog post](https://blog.lurk-lang.org/posts/arecibo-supernova/#technical-release-note-supernova-protocol-integration-into-nova) goes into our construction,
  and links to two more specialized notes on [the `CompressedSNARK` for Supernova](https://hackmd.io/@adr1anh/BJw1g0aBT) along with our variant of the [public input padding issue](https://hackmd.io/@adr1anh/Sy08YaVBa).
- the Readme at `src/supernova/Readme.md`

This backports the following Arecibo PRs:
- lurk-lang/arecibo#2
- lurk-lang/arecibo#3
- lurk-lang/arecibo#10
- lurk-lang/arecibo#16
- lurk-lang/arecibo#23
- lurk-lang/arecibo#30
- lurk-lang/arecibo#28
- lurk-lang/arecibo#41
- lurk-lang/arecibo#45
- lurk-lang/arecibo#50
- lurk-lang/arecibo#56
- lurk-lang/arecibo#51
- lurk-lang/arecibo#72
- lurk-lang/arecibo#92
- lurk-lang/arecibo#95
- lurk-lang/arecibo#97
- lurk-lang/arecibo#101
- lurk-lang/arecibo#110
- lurk-lang/arecibo#106
- lurk-lang/arecibo#112
- lurk-lang/arecibo#114
- lurk-lang/arecibo#119
- lurk-lang/arecibo#120
- lurk-lang/arecibo#127
- lurk-lang/arecibo#123
- lurk-lang/arecibo#131
- lurk-lang/arecibo#174
- lurk-lang/arecibo#175
- lurk-lang/arecibo#182

Co-authored-by: WYATT <wyattbenno@gmail.com>
Co-authored-by: Hanting Zhang <hantingz@usc.edu>
Co-authored-by: Ming <hero78119@gmail.com>
Co-authored-by: porcuquine <porcuquine@users.noreply.github.com>
Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com>
Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com>
Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>
huitseeker added a commit to lurk-lang/Nova that referenced this pull request Jan 16, 2024
@huitseeker @wyattbenno777
@winston-h-zhang @hero78119 @porcuquine @samuelburnham @mpenciak @adr1anh
feat: implement SuperNova
9e3a41f 
This implements [Supernova](https://eprint.iacr.org/2022/1758), allowing:
- a 'pay-as-you-go' cost structure for folding operations, through the SuperNova folding scheme,
- a final SNARK that efficiently compresses an instance of this folded proof, through batching techniques.

References:
- the [blog post](https://blog.lurk-lang.org/posts/arecibo-supernova/#technical-release-note-supernova-protocol-integration-into-nova) goes into our construction,
  and links to two more specialized notes on [the `CompressedSNARK` for Supernova](https://hackmd.io/@adr1anh/BJw1g0aBT) along with our variant of the [public input padding issue](https://hackmd.io/@adr1anh/Sy08YaVBa).
- the Readme at `src/supernova/Readme.md`

This backports the following Arecibo PRs:
- lurk-lang/arecibo#2
- lurk-lang/arecibo#3
- lurk-lang/arecibo#10
- lurk-lang/arecibo#16
- lurk-lang/arecibo#23
- lurk-lang/arecibo#30
- lurk-lang/arecibo#28
- lurk-lang/arecibo#41
- lurk-lang/arecibo#45
- lurk-lang/arecibo#50
- lurk-lang/arecibo#56
- lurk-lang/arecibo#51
- lurk-lang/arecibo#72
- lurk-lang/arecibo#92
- lurk-lang/arecibo#95
- lurk-lang/arecibo#97
- lurk-lang/arecibo#101
- lurk-lang/arecibo#110
- lurk-lang/arecibo#106
- lurk-lang/arecibo#112
- lurk-lang/arecibo#114
- lurk-lang/arecibo#119
- lurk-lang/arecibo#120
- lurk-lang/arecibo#127
- lurk-lang/arecibo#123
- lurk-lang/arecibo#131
- lurk-lang/arecibo#174
- lurk-lang/arecibo#175
- lurk-lang/arecibo#182

Co-authored-by: WYATT <wyattbenno@gmail.com>
Co-authored-by: Hanting Zhang <hantingz@usc.edu>
Co-authored-by: Ming <hero78119@gmail.com>
Co-authored-by: porcuquine <porcuquine@users.noreply.github.com>
Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com>
Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com>
Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>
huitseeker added a commit to lurk-lang/Nova that referenced this pull request Jan 25, 2024
@huitseeker @wyattbenno777
@winston-h-zhang @hero78119 @porcuquine @samuelburnham @mpenciak @adr1anh
feat: implement SuperNova
d5ddff4 
This implements [Supernova](https://eprint.iacr.org/2022/1758), allowing:
- a 'pay-as-you-go' cost structure for folding operations, through the SuperNova folding scheme,
- a final SNARK that efficiently compresses an instance of this folded proof, through batching techniques.

References:
- the [blog post](https://blog.lurk-lang.org/posts/arecibo-supernova/#technical-release-note-supernova-protocol-integration-into-nova) goes into our construction,
  and links to two more specialized notes on [the `CompressedSNARK` for Supernova](https://hackmd.io/@adr1anh/BJw1g0aBT) along with our variant of the [public input padding issue](https://hackmd.io/@adr1anh/Sy08YaVBa).
- the Readme at `src/supernova/Readme.md`

This backports the following Arecibo PRs:
- lurk-lang/arecibo#2
- lurk-lang/arecibo#3
- lurk-lang/arecibo#10
- lurk-lang/arecibo#16
- lurk-lang/arecibo#23
- lurk-lang/arecibo#30
- lurk-lang/arecibo#28
- lurk-lang/arecibo#41
- lurk-lang/arecibo#45
- lurk-lang/arecibo#50
- lurk-lang/arecibo#56
- lurk-lang/arecibo#51
- lurk-lang/arecibo#72
- lurk-lang/arecibo#92
- lurk-lang/arecibo#95
- lurk-lang/arecibo#97
- lurk-lang/arecibo#101
- lurk-lang/arecibo#110
- lurk-lang/arecibo#106
- lurk-lang/arecibo#112
- lurk-lang/arecibo#114
- lurk-lang/arecibo#119
- lurk-lang/arecibo#120
- lurk-lang/arecibo#127
- lurk-lang/arecibo#123
- lurk-lang/arecibo#131
- lurk-lang/arecibo#174
- lurk-lang/arecibo#175
- lurk-lang/arecibo#182

Co-authored-by: WYATT <wyattbenno@gmail.com>
Co-authored-by: Hanting Zhang <hantingz@usc.edu>
Co-authored-by: Ming <hero78119@gmail.com>
Co-authored-by: porcuquine <porcuquine@users.noreply.github.com>
Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com>
Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com>
Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>
huitseeker added a commit to lurk-lang/Nova that referenced this pull request Jan 25, 2024
@huitseeker @wyattbenno777
@winston-h-zhang @hero78119 @porcuquine @samuelburnham @mpenciak @adr1anh
feat: implement SuperNova
a6688bd 
This implements [Supernova](https://eprint.iacr.org/2022/1758), allowing:
- a 'pay-as-you-go' cost structure for folding operations, through the SuperNova folding scheme,
- a final SNARK that efficiently compresses an instance of this folded proof, through batching techniques.

References:
- the [blog post](https://blog.lurk-lang.org/posts/arecibo-supernova/#technical-release-note-supernova-protocol-integration-into-nova) goes into our construction,
  and links to two more specialized notes on [the `CompressedSNARK` for Supernova](https://hackmd.io/@adr1anh/BJw1g0aBT) along with our variant of the [public input padding issue](https://hackmd.io/@adr1anh/Sy08YaVBa).
- the Readme at `src/supernova/Readme.md`

This backports the following Arecibo PRs:
- lurk-lang/arecibo#2
- lurk-lang/arecibo#3
- lurk-lang/arecibo#10
- lurk-lang/arecibo#16
- lurk-lang/arecibo#23
- lurk-lang/arecibo#30
- lurk-lang/arecibo#28
- lurk-lang/arecibo#41
- lurk-lang/arecibo#45
- lurk-lang/arecibo#50
- lurk-lang/arecibo#56
- lurk-lang/arecibo#51
- lurk-lang/arecibo#72
- lurk-lang/arecibo#92
- lurk-lang/arecibo#95
- lurk-lang/arecibo#97
- lurk-lang/arecibo#101
- lurk-lang/arecibo#110
- lurk-lang/arecibo#106
- lurk-lang/arecibo#112
- lurk-lang/arecibo#114
- lurk-lang/arecibo#119
- lurk-lang/arecibo#120
- lurk-lang/arecibo#127
- lurk-lang/arecibo#123
- lurk-lang/arecibo#131
- lurk-lang/arecibo#174
- lurk-lang/arecibo#175
- lurk-lang/arecibo#182

Co-authored-by: WYATT <wyattbenno@gmail.com>
Co-authored-by: Hanting Zhang <hantingz@usc.edu>
Co-authored-by: Ming <hero78119@gmail.com>
Co-authored-by: porcuquine <porcuquine@users.noreply.github.com>
Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com>
Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com>
Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>
huitseeker added a commit to lurk-lang/Nova that referenced this pull request Jan 31, 2024
@huitseeker @wyattbenno777
@winston-h-zhang @hero78119 @porcuquine @samuelburnham @mpenciak @adr1anh
feat: implement SuperNova
60febcb 
This implements [Supernova](https://eprint.iacr.org/2022/1758), allowing:
- a 'pay-as-you-go' cost structure for folding operations, through the SuperNova folding scheme,
- a final SNARK that efficiently compresses an instance of this folded proof, through batching techniques.

References:
- the [blog post](https://blog.lurk-lang.org/posts/arecibo-supernova/#technical-release-note-supernova-protocol-integration-into-nova) goes into our construction,
  and links to two more specialized notes on [the `CompressedSNARK` for Supernova](https://hackmd.io/@adr1anh/BJw1g0aBT) along with our variant of the [public input padding issue](https://hackmd.io/@adr1anh/Sy08YaVBa).
- the Readme at `src/supernova/Readme.md`

This backports the following Arecibo PRs:
- lurk-lang/arecibo#2
- lurk-lang/arecibo#3
- lurk-lang/arecibo#10
- lurk-lang/arecibo#16
- lurk-lang/arecibo#23
- lurk-lang/arecibo#30
- lurk-lang/arecibo#28
- lurk-lang/arecibo#41
- lurk-lang/arecibo#45
- lurk-lang/arecibo#50
- lurk-lang/arecibo#56
- lurk-lang/arecibo#51
- lurk-lang/arecibo#72
- lurk-lang/arecibo#92
- lurk-lang/arecibo#95
- lurk-lang/arecibo#97
- lurk-lang/arecibo#101
- lurk-lang/arecibo#110
- lurk-lang/arecibo#106
- lurk-lang/arecibo#112
- lurk-lang/arecibo#114
- lurk-lang/arecibo#119
- lurk-lang/arecibo#120
- lurk-lang/arecibo#127
- lurk-lang/arecibo#123
- lurk-lang/arecibo#131
- lurk-lang/arecibo#174
- lurk-lang/arecibo#175
- lurk-lang/arecibo#182

Co-authored-by: WYATT <wyattbenno@gmail.com>
Co-authored-by: Hanting Zhang <hantingz@usc.edu>
Co-authored-by: Ming <hero78119@gmail.com>
Co-authored-by: porcuquine <porcuquine@users.noreply.github.com>
Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com>
Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com>
Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>
huitseeker added a commit to lurk-lang/Nova that referenced this pull request Feb 21, 2024
@huitseeker @wyattbenno777
@winston-h-zhang @hero78119 @porcuquine @samuelburnham @mpenciak @adr1anh
feat: implement SuperNova
5d433b8 
This implements [Supernova](https://eprint.iacr.org/2022/1758), allowing:
- a 'pay-as-you-go' cost structure for folding operations, through the SuperNova folding scheme,
- a final SNARK that efficiently compresses an instance of this folded proof, through batching techniques.

References:
- the [blog post](https://blog.lurk-lang.org/posts/arecibo-supernova/#technical-release-note-supernova-protocol-integration-into-nova) goes into our construction,
  and links to two more specialized notes on [the `CompressedSNARK` for Supernova](https://hackmd.io/@adr1anh/BJw1g0aBT) along with our variant of the [public input padding issue](https://hackmd.io/@adr1anh/Sy08YaVBa).
- the Readme at `src/supernova/Readme.md`

This backports the following Arecibo PRs:
- lurk-lang/arecibo#2
- lurk-lang/arecibo#3
- lurk-lang/arecibo#10
- lurk-lang/arecibo#16
- lurk-lang/arecibo#23
- lurk-lang/arecibo#30
- lurk-lang/arecibo#28
- lurk-lang/arecibo#41
- lurk-lang/arecibo#45
- lurk-lang/arecibo#50
- lurk-lang/arecibo#56
- lurk-lang/arecibo#51
- lurk-lang/arecibo#72
- lurk-lang/arecibo#92
- lurk-lang/arecibo#95
- lurk-lang/arecibo#97
- lurk-lang/arecibo#101
- lurk-lang/arecibo#110
- lurk-lang/arecibo#106
- lurk-lang/arecibo#112
- lurk-lang/arecibo#114
- lurk-lang/arecibo#119
- lurk-lang/arecibo#120
- lurk-lang/arecibo#127
- lurk-lang/arecibo#123
- lurk-lang/arecibo#131
- lurk-lang/arecibo#174
- lurk-lang/arecibo#175
- lurk-lang/arecibo#182

Co-authored-by: WYATT <wyattbenno@gmail.com>
Co-authored-by: Hanting Zhang <hantingz@usc.edu>
Co-authored-by: Ming <hero78119@gmail.com>
Co-authored-by: porcuquine <porcuquine@users.noreply.github.com>
Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com>
Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com>
Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>
huitseeker added a commit to lurk-lang/Nova that referenced this pull request Mar 7, 2024
@huitseeker @wyattbenno777
@winston-h-zhang @hero78119 @porcuquine @samuelburnham @mpenciak @adr1anh
feat: implement SuperNova
eba0948 
This implements [Supernova](https://eprint.iacr.org/2022/1758), allowing:
- a 'pay-as-you-go' cost structure for folding operations, through the SuperNova folding scheme,
- a final SNARK that efficiently compresses an instance of this folded proof, through batching techniques.

References:
- the [blog post](https://blog.lurk-lang.org/posts/arecibo-supernova/#technical-release-note-supernova-protocol-integration-into-nova) goes into our construction,
  and links to two more specialized notes on [the `CompressedSNARK` for Supernova](https://hackmd.io/@adr1anh/BJw1g0aBT) along with our variant of the [public input padding issue](https://hackmd.io/@adr1anh/Sy08YaVBa).
- the Readme at `src/supernova/Readme.md`

This backports the following Arecibo PRs:
- lurk-lang/arecibo#2
- lurk-lang/arecibo#3
- lurk-lang/arecibo#10
- lurk-lang/arecibo#16
- lurk-lang/arecibo#23
- lurk-lang/arecibo#30
- lurk-lang/arecibo#28
- lurk-lang/arecibo#41
- lurk-lang/arecibo#45
- lurk-lang/arecibo#50
- lurk-lang/arecibo#56
- lurk-lang/arecibo#51
- lurk-lang/arecibo#72
- lurk-lang/arecibo#92
- lurk-lang/arecibo#95
- lurk-lang/arecibo#97
- lurk-lang/arecibo#101
- lurk-lang/arecibo#110
- lurk-lang/arecibo#106
- lurk-lang/arecibo#112
- lurk-lang/arecibo#114
- lurk-lang/arecibo#119
- lurk-lang/arecibo#120
- lurk-lang/arecibo#127
- lurk-lang/arecibo#123
- lurk-lang/arecibo#131
- lurk-lang/arecibo#174
- lurk-lang/arecibo#175
- lurk-lang/arecibo#182

Co-authored-by: WYATT <wyattbenno@gmail.com>
Co-authored-by: Hanting Zhang <hantingz@usc.edu>
Co-authored-by: Ming <hero78119@gmail.com>
Co-authored-by: porcuquine <porcuquine@users.noreply.github.com>
Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com>
Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com>
Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>
huitseeker added a commit to lurk-lang/Nova that referenced this pull request May 2, 2024
@huitseeker @wyattbenno777
@winston-h-zhang @hero78119 @porcuquine @samuelburnham @mpenciak @adr1anh
feat: implement SuperNova
c642217 
This implements [Supernova](https://eprint.iacr.org/2022/1758), allowing:
- a 'pay-as-you-go' cost structure for folding operations, through the SuperNova folding scheme,
- a final SNARK that efficiently compresses an instance of this folded proof, through batching techniques.

References:
- the [blog post](https://blog.lurk-lang.org/posts/arecibo-supernova/#technical-release-note-supernova-protocol-integration-into-nova) goes into our construction,
  and links to two more specialized notes on [the `CompressedSNARK` for Supernova](https://hackmd.io/@adr1anh/BJw1g0aBT) along with our variant of the [public input padding issue](https://hackmd.io/@adr1anh/Sy08YaVBa).
- the Readme at `src/supernova/Readme.md`

This backports the following Arecibo PRs:
- lurk-lang/arecibo#2
- lurk-lang/arecibo#3
- lurk-lang/arecibo#10
- lurk-lang/arecibo#16
- lurk-lang/arecibo#23
- lurk-lang/arecibo#30
- lurk-lang/arecibo#28
- lurk-lang/arecibo#41
- lurk-lang/arecibo#45
- lurk-lang/arecibo#50
- lurk-lang/arecibo#56
- lurk-lang/arecibo#51
- lurk-lang/arecibo#72
- lurk-lang/arecibo#92
- lurk-lang/arecibo#95
- lurk-lang/arecibo#97
- lurk-lang/arecibo#101
- lurk-lang/arecibo#110
- lurk-lang/arecibo#106
- lurk-lang/arecibo#112
- lurk-lang/arecibo#114
- lurk-lang/arecibo#119
- lurk-lang/arecibo#120
- lurk-lang/arecibo#127
- lurk-lang/arecibo#123
- lurk-lang/arecibo#131
- lurk-lang/arecibo#174
- lurk-lang/arecibo#175
- lurk-lang/arecibo#182

Co-authored-by: WYATT <wyattbenno@gmail.com>
Co-authored-by: Hanting Zhang <hantingz@usc.edu>
Co-authored-by: Ming <hero78119@gmail.com>
Co-authored-by: porcuquine <porcuquine@users.noreply.github.com>
Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com>
Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com>
Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>
huitseeker added a commit to lurk-lang/Nova that referenced this pull request May 3, 2024
@huitseeker @wyattbenno777
@winston-h-zhang @hero78119 @porcuquine @samuelburnham @mpenciak @adr1anh
feat: implement SuperNova
9bdeca0 
This implements [Supernova](https://eprint.iacr.org/2022/1758), allowing:
- a 'pay-as-you-go' cost structure for folding operations, through the SuperNova folding scheme,
- a final SNARK that efficiently compresses an instance of this folded proof, through batching techniques.

References:
- the [blog post](https://blog.lurk-lang.org/posts/arecibo-supernova/#technical-release-note-supernova-protocol-integration-into-nova) goes into our construction,
  and links to two more specialized notes on [the `CompressedSNARK` for Supernova](https://hackmd.io/@adr1anh/BJw1g0aBT) along with our variant of the [public input padding issue](https://hackmd.io/@adr1anh/Sy08YaVBa).
- the Readme at `src/supernova/Readme.md`

This backports the following Arecibo PRs:
- lurk-lang/arecibo#2
- lurk-lang/arecibo#3
- lurk-lang/arecibo#10
- lurk-lang/arecibo#16
- lurk-lang/arecibo#23
- lurk-lang/arecibo#30
- lurk-lang/arecibo#28
- lurk-lang/arecibo#41
- lurk-lang/arecibo#45
- lurk-lang/arecibo#50
- lurk-lang/arecibo#56
- lurk-lang/arecibo#51
- lurk-lang/arecibo#72
- lurk-lang/arecibo#92
- lurk-lang/arecibo#95
- lurk-lang/arecibo#97
- lurk-lang/arecibo#101
- lurk-lang/arecibo#110
- lurk-lang/arecibo#106
- lurk-lang/arecibo#112
- lurk-lang/arecibo#114
- lurk-lang/arecibo#119
- lurk-lang/arecibo#120
- lurk-lang/arecibo#127
- lurk-lang/arecibo#123
- lurk-lang/arecibo#131
- lurk-lang/arecibo#174
- lurk-lang/arecibo#175
- lurk-lang/arecibo#182

Co-authored-by: WYATT <wyattbenno@gmail.com>
Co-authored-by: Hanting Zhang <hantingz@usc.edu>
Co-authored-by: Ming <hero78119@gmail.com>
Co-authored-by: porcuquine <porcuquine@users.noreply.github.com>
Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com>
Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com>
Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>
huitseeker added a commit to lurk-lang/Nova that referenced this pull request Jun 8, 2024
@huitseeker @wyattbenno777
@winston-h-zhang @hero78119 @porcuquine @samuelburnham @mpenciak @adr1anh
feat: implement SuperNova
f65fee7 
This implements [Supernova](https://eprint.iacr.org/2022/1758), allowing:
- a 'pay-as-you-go' cost structure for folding operations, through the SuperNova folding scheme,
- a final SNARK that efficiently compresses an instance of this folded proof, through batching techniques.

References:
- the [blog post](https://blog.lurk-lang.org/posts/arecibo-supernova/#technical-release-note-supernova-protocol-integration-into-nova) goes into our construction,
  and links to two more specialized notes on [the `CompressedSNARK` for Supernova](https://hackmd.io/@adr1anh/BJw1g0aBT) along with our variant of the [public input padding issue](https://hackmd.io/@adr1anh/Sy08YaVBa).
- the Readme at `src/supernova/Readme.md`

This backports the following Arecibo PRs:
- lurk-lang/arecibo#2
- lurk-lang/arecibo#3
- lurk-lang/arecibo#10
- lurk-lang/arecibo#16
- lurk-lang/arecibo#23
- lurk-lang/arecibo#30
- lurk-lang/arecibo#28
- lurk-lang/arecibo#41
- lurk-lang/arecibo#45
- lurk-lang/arecibo#50
- lurk-lang/arecibo#56
- lurk-lang/arecibo#51
- lurk-lang/arecibo#72
- lurk-lang/arecibo#92
- lurk-lang/arecibo#95
- lurk-lang/arecibo#97
- lurk-lang/arecibo#101
- lurk-lang/arecibo#110
- lurk-lang/arecibo#106
- lurk-lang/arecibo#112
- lurk-lang/arecibo#114
- lurk-lang/arecibo#119
- lurk-lang/arecibo#120
- lurk-lang/arecibo#127
- lurk-lang/arecibo#123
- lurk-lang/arecibo#131
- lurk-lang/arecibo#174
- lurk-lang/arecibo#175
- lurk-lang/arecibo#182

Co-authored-by: WYATT <wyattbenno@gmail.com>
Co-authored-by: Hanting Zhang <hantingz@usc.edu>
Co-authored-by: Ming <hero78119@gmail.com>
Co-authored-by: porcuquine <porcuquine@users.noreply.github.com>
Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com>
Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com>
Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huitseeker huitseeker huitseeker approved these changes

@porcuquine porcuquine porcuquine left review comments

Assignees

No one assigned

Labels

supernova

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adr1anh @porcuquine @huitseeker