fix: merge main and resolve conflicts for embedded unexported methods#195
Open
xgopilot[bot] wants to merge 3 commits intofix/embedded-unexported-methodsfrom
Open
fix: merge main and resolve conflicts for embedded unexported methods#195xgopilot[bot] wants to merge 3 commits intofix/embedded-unexported-methodsfrom
xgopilot[bot] wants to merge 3 commits intofix/embedded-unexported-methodsfrom
Conversation
…methods (goplus#1597) Previously, when a type embedded another type from a different package, the unexported methods inherited from the embedded type would have nil function pointers (Ifn_) in the method table. This caused runtime panics when interfaces with unexported methods (like types.Object) were used. The fix removes the skipfn logic that was setting Ifn_ to nil for methods from other packages. Now all methods, including unexported ones from embedded types, get valid function pointers generated. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Resolve conflicts by regenerating out.ll files using gentests. The fix for embedded type's unexported methods is preserved. Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: luoliwoshang <51194195+luoliwoshang@users.noreply.github.com>
Merged
3 tasks
luoliwoshang
force-pushed
the
fix/embedded-unexported-methods
branch
from
f2717a8 to
f315ea4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by @luoliwoshang
Summary