fix: make sure that errors from before hook are reported
#196
+27
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@lukeed sorry to be a bother with the ping, just wondering if we can get this looked at? I've loved using |
|
Please review this for merge. It's a huge quality-of-life improvement to this library. |
|
Just stumbled upon this bug. Is there any chance of it getting merged anytime soon? PS: @lukeed Thanks for this library, it's easily the fastest JS test runner I've ever used! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added in a try/catch to catch any errors that happen in the
beforehook so that they can be reported on and properly have theexitcode of1. If you'd like me to update any of the code styles, let me know. Been loving this test runner so far.Closes #191
Closes #201