add support for readline #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I believe this PR can work even if on windows. And prompt-toolkit or pyreadline3 should be another unrelated PR. |
Owner
|
Awesome! |
Contributor
Author
|
How about providing a command opiton |
Owner
|
Why would you want to change the history file? |
Contributor
Author
|
Maybe someone wants to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #177
#181 is too large because it contains too many commits which have different
functions, so I think if it is split to many PRs, you can review it more
easily. This PR cherry-picks the commits only related to readline and squash them
to one commit. Thanks.