Repository navigation
fix(ci): patch pnpm bootstrap and selected toolchain - #146
Merged
Merged
Conversation
6 of 13 tasks
fix(tests): preserve binary PDF stream boundaries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Patch both pnpm toolchain layers affected by GHSA-qrv3-253h-g69c. The frontend setup warning belongs to the action bootstrap's package tree, separately from the clean application dependency audit. The previously selected project package manager is also affected;
--ignore-scriptsis not a mitigation for this advisory..github/workflows/frontend.yaml0977fd99725f1db4007ccb2928dbb4e90d06cc86. The upstream release updates the bootstrap pnpm to 11.19.0.package.jsontests/Pdf/MPdfConverterTest.phpThis PR combines the two-line toolchain correction with the test-only reader fix reviewed in #147: three files, 132 additions and 11 deletions. Workflow permissions, triggers, inputs and commands are unchanged. Dependency declarations, overrides and
pnpm-lock.yamlare unchanged. The existing OpenSpec archive/canonical changes and delivery addendum remain local and are excluded.Provenance
Validation
git diff --check../php-cs-fixer.sh core '--dry-run --using-cache=no'.No package manager was installed or executed locally for this change; static provenance is not runtime evidence. The old runtime warning is recorded in main run 34694756750. The separate legacy-layout warning is not claimed fixed. No warning suppression or force-fix is added.
Types of changes
Checklist
composer code-check)Full
composer code-checkwas not run; the author agreement checkbox is left for the maintainer. This PR was reviewed as a draft and merged after explicit maintainer authorization. No manual deployment, application-data changes or unrelated warning remediation was performed.Integrated test correction: #147
With explicit maintainer authorization, #147 was merged normally into this branch as
4d8e421cd0d75f60a9cc26f12c4e71abd41c0014on 2026-09-12 at 18:16:30 UTC. No protection bypass or branch deletion was used. At that checkpoint, the tracker remained a draft and main publication was not yet authorized.The child had nine successful checks on tested merge
60d47298bf03446d15bbe7480fa806c03e552119, including 4,805 full-suite tests on each PHP 8.2–8.5, migration round trips, application/test PHPStan, and frontend validation with the patched toolchain. Its 139-line test-only correction leaves production sanitization unchanged. Local independent synthetic verification passed 18 tests and 142 assertions.Fresh CI on tracker head
4d8e421cd0d75f60a9cc26f12c4e71abd41c0014passed all nine checks, through tested mergec438750d82837394b95174270be4946b3e04507c. Child success does not replace that validation. The earlier head12d9c080cb59a75ac047f9f54d4979e5dbf92d7bhad eight of nine checks pass and a PHP 8.5 PDF-test failure. The binary-boundary reader defect is independently demonstrated, but its causality for that historical failure remains unproven because assertion details and artifacts are unavailable.Combined review scope is 143 changed lines across three files, with the test correction reviewed independently in #147. Expense archive/canonical documents and the delivery addendum remain excluded. Sass, legacy-layout, abandoned-package and release-lookup warnings remain separate maintenance items. The lock guard's trusted-author bypass is not byte-integrity proof; lock identity was checked independently.
Final publication evidence
After explicit maintainer approval, this PR merged normally into main as
067e5958c5279ae84f59b2af8f4ed6668400d67don 2026-09-12 at 18:48:57 UTC. Fresh post-merge executions for that exact SHA completed successfully: seven workflows and ten checks.The version bot then created direct descendant
93acb75a7ce5b3adef3a319dd0850f52a6ec1deb, changing onlysrc/Constants.phpto version2.62.166/ ID26366. Its[skip ci]commit has no independently observed CI run. Neither CI nor this metadata-only descendant proves production deployment identity; no manual deployment was executed.Known Sass, legacy-layout, release API, abandoned-package and deprecation warnings remain. The expense documentation remains local, excluded from this publication, and subject to a separate publication decision.