Skip to content

fix: change PROMPT constant to reduce collision #3970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: change PROMPT constant to reduce collision #3970

wants to merge 1 commit into from

Conversation

@geoffreyangus
Copy link
Contributor

@geoffreyangus geoffreyangus commented Mar 19, 2024

title.

@arnavgarg1
Copy link
Contributor

arnavgarg1 commented Mar 19, 2024

Nice!!!

@jeffkinnison
Copy link
Contributor

jeffkinnison commented Mar 19, 2024

Did we determine why variations of "prompt" were being ignored in the template (ex. "Prompt", "prompT", "PrOmPt")?

@github-actions
Copy link

github-actions bot commented Mar 19, 2024

Unit Test Results

       6 files  ±       0         6 suites  ±0   26m 51s ⏱️ + 9m 48s
2 993 tests +2 981  2 981 ✔️ +2 972  12 💤 +9  0 ❌ ±0 
3 029 runs  +2 969  3 005 ✔️ +2 963  24 💤 +6  0 ❌ ±0 

Results for commit fc5c2ff. ± Comparison against base commit c09d5dc.

RahulVadisetty91
RahulVadisetty91 reviewed Sep 16, 2024
View reviewed changes
Copy link

@RahulVadisetty91 RahulVadisetty91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w129

Choose one of the two values for PROMPT and remove the reassignment. If the value prompt is intended to replace "prompt", then remove the first assignment.

PROMPT = "prompt" # Keep only one assignment to avoid conflicts.

@mhabedank
Copy link
Collaborator

mhabedank commented Oct 21, 2024

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffkinnison jeffkinnison jeffkinnison approved these changes

@arnavgarg1 arnavgarg1 arnavgarg1 approved these changes

@w4nderlust w4nderlust Awaiting requested review from w4nderlust w4nderlust is a code owner

@tgaddair tgaddair Awaiting requested review from tgaddair tgaddair is a code owner

@justinxzhao justinxzhao Awaiting requested review from justinxzhao justinxzhao is a code owner

@Infernaught Infernaught Awaiting requested review from Infernaught Infernaught is a code owner

@alexsherstinsky alexsherstinsky Awaiting requested review from alexsherstinsky alexsherstinsky is a code owner

+1 more reviewer

@RahulVadisetty91 RahulVadisetty91 RahulVadisetty91 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@geoffreyangus @arnavgarg1 @jeffkinnison @mhabedank @RahulVadisetty91