fix duplicate items in module-list: issue 289# #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanxq73
changed the title
wanxq73
changed the title
|
Hey! You can use keywords to link issues in PR: Using keywords in issues and pull requests - GitHub Docs. Please note that those keywords do not work in title. |
| { | ||
| if (obj is ModuleCacheKey o) | ||
| { | ||
| return this.GetHashCode() == o.GetHashCode(); |
There was a problem hiding this comment.
Thank you for the fix.
But I believe this is not a good approach to compare using hash codes because there can be hash collisions. If you can make a pull request with direct comparisons on the properties, I'll merge it in to my branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify DependencyModuleList.xaml.cs:
Close Duplicated items in module-list #289