Skip to content

Conversation

@sfan5
Copy link
Collaborator

@sfan5 sfan5 commented Nov 2, 2025

  • fix memory leak
  • fix y2038 bug
  • move to advanced settings, clarify description
  • a few small code cleanups

Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Makes sense. Thank you.

As a possible improvement, we could consider to log a warning if sizeof(time_t) < 8.

@sfan5
Copy link
Collaborator Author

sfan5 commented Nov 3, 2025

We could, but IMO it's the user's responsibility to know if their stdlib/libc is Y2038-compliant or not.

@sfan5 sfan5 requested a review from appgurueu November 3, 2025 17:20
Copy link
Contributor

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is reasonable as-is 👍

p.s. another possible improvement: action_latest_buffer could profit from being turned into a std::deque.

@sfan5 sfan5 merged commit 2368126 into luanti-org:master Nov 5, 2025
17 checks passed
@sfan5 sfan5 deleted the rb1234 branch November 5, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants