Tune "block send throttling while building" optimization #16614
Merged
+29
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhofhansl
reviewed
Oct 26, 2025
| if (m_time_from_building < m_min_time_from_building) { | ||
| max_simul_sends_usually | ||
| = LIMITED_MAX_SIMULTANEOUS_BLOCK_SENDS; | ||
| max_simul_sends_usually *= LIMITED_BLOCK_SENDS_FACTOR; |
Contributor
There was a problem hiding this comment.
Interesting. For larger viewing_ranges (or actual servers with some latency to the client) max_simultaneous_block_sends_per_client has to be increased significantly. For 1000-2000 I have it set to 512, for example.
Contributor
|
Can we just get rid of that logic entirely. |
Collaborator
Author
|
We can, the new logic is just based on me guessing that this could still be useful. |
Collaborator
Author
|
It at least wouldn't hurt to merge this for the time being. After all servers can still disable this optimization(?) entirely using a setting. 🤷 |
SmallJoker
approved these changes
Nov 3, 2025
Member
SmallJoker
left a comment
SmallJoker
left a comment
There was a problem hiding this comment.
Tested according to instructions.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it can lead to terrain not loading/updating at all if you're constantly building and moving.
for more see the irc logs: https://irc.luanti.org/luanti/2025-10-26#i_6293100
To do
This PR is Ready for Review.
How to test
🤷