-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add Warm lighting #16560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Warm lighting #16560
Conversation
|
This needs to be configurable using a server API, not the client. |
|
See here for colored lighting: #2670 Imo, the feature of this PR is too arbitrary and inflexible. Also, it could make things more complicated if we will eventually add a colored lighting API for artificial lights. |
|
Please, no. It would make much more sense to make artificialLight modifiable, but that would also affect all existing light sources and could potentially hinder the global illumination implementation (the difference between the adjustable color of global illumination and artificial light could be too big) Therefore, I wouldn't recommend touching this at all until global illumination is added to Luanti |
|
im working on making it configurable by the client using another setting. (i can make it configurable by the server as well)
Clarify "global illumination". |
In case that wasn't clear, this must be server-controllable and may be client-controllable (as long as the server has the last word). |
|
#15417 proposes an option to set the artificial light color freely |
|
because of the fact that #15417 is older, perhaps it'd be best to go through with that one. |
Goal of this PR is to enhance Luanti's shaders with Warm artificial lighting
This PR adds warm lighting to Luanti as a simple but great way to enhance Luanti's visuals
When enabled will make light sources emit warmer lighting giving a more realistic/cozy (this effect is not very noticeable if the area you put the light has a lot of sunlight)
Before/After images:

Ready for Review
How to test
(optional but recommended is to enable "Filmic Tone mapping" under "Post Processing")