TEST: remove invalid yield usage from spec example #1519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using yield outside method definition is invalid, and with ruby3.3.0dev, this usage in spec example file causes spec testsuite failure. So to make test pass also on ruby3.3, remove this usage. Fixes lsegal#1514 .
lsegal
requested changes
Nov 14, 2023
Owner
lsegal
left a comment
lsegal
left a comment
There was a problem hiding this comment.
Unfortunately this still needs to be tested for older Ruby versions that yard still supports where the syntax is still legal although semantically unsupported.
I think this specific case should probably be moved into a version specific if block like we do for other version specific features.
Owner
|
Revisiting this since it seems like there's no way to test without 3.3 support here, which is unfortunate. |
Owner
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using yield outside method definition is invalid, and with ruby3.3.0dev, this usage in spec example file causes spec testsuite failure.
So to make test pass also on ruby3.3, remove this usage.
Fixes #1514 .
Completed Tasks
bundle exec rakelocally (if code is attached to PR).