Skip to content

Fix error when @option with non-method #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Fix error when @option with non-method #1508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions spec/templates/tag_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,4 +49,16 @@ module Foo; end
.not_to raise_error
end
end

describe "option tags on non-methods" do
it "does not display @option tags on non-method objects" do
YARD.parse_string <<-'eof'
# @option opts name [#to_s] ('bar') the name
module Foo; end
eof

expect { Registry.at('Foo').format(html_options) }
.not_to raise_error
end
end
end
2 changes: 1 addition & 1 deletion templates/default/tags/html/option.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<% if object.has_tag?(:option) %>
<% if object.has_tag?(:option) && object.respond_to?(:parameters) %>
<% object.parameters.each do |param, default| %>
<% tags = object.tags(:option).select {|x| x.name.to_s == param.to_s.sub(/^\*+|:$/, '') } %>
<% next if tags.empty? %>
Expand Down