Skip to content

General: Code clean up for prior employee fixes#1910

Open
sachmii wants to merge 5 commits intomainfrom
general/1905-further-employee-fixes-and-adaptations
Open

General: Code clean up for prior employee fixes#1910
sachmii wants to merge 5 commits intomainfrom
general/1905-further-employee-fixes-and-adaptations

Conversation

@sachmii
Copy link
Contributor

@sachmii sachmii commented Feb 13, 2026

Checklist

General

Server

  • Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
  • I strictly followed the principle of data economy for all database calls.
  • I strictly followed the server coding and design guidelines.
  • I documented the Java code using JavaDoc style.

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
  • I strictly followed the principle of data economy for all client-server REST calls.
  • I strictly followed the client coding and design guidelines.
  • I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
  • I documented the TypeScript code using JSDoc style.

Motivation and Context

Code clean up for a prior PR. Closes #1905.

Description

  • Added a research-group professors endpoint and updated the job creation flow to consume it, simplifying supervising‑professor normalization and loading logic.
  • Renamed the research‑group jobs endpoint/service method (from professor‑scoped naming) and updated related frontend calls, mocks, and tests.
  • Introduced UserNotFoundException for supervising‑professor lookup failures.
  • Adjusted init/load behavior to reduce redundant requests and keep selections consistent.
  • Added more tests for my-positions-page.

Steps for Testing

Prerequisites:

  1. Log in to TumApply as Employee
  2. Try to create a positions
  3. Should preselect one professor of the research group as supervising professor

Review Progress

Code Review

  • Code Review 1

Manual Tests

  • Test 1

Test Coverage

Warning: Both client and server tests failed. Coverage could not be fully measured. Please check the workflow logs.

Last updated: 2026-02-13 14:09:29 UTC

Screenshots

@sachmii sachmii self-assigned this Feb 13, 2026
@sachmii sachmii linked an issue Feb 13, 2026 that may be closed by this pull request
@github-actions github-actions bot added server Pull requests that update Java code. (Added Automatically!) client Pull requests that update TypeScript code. (Added Automatically!) tests user management Code changes in user management module. job Code changes in job module. labels Feb 13, 2026
@github-actions
Copy link
Contributor

@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@sachmii sachmii marked this pull request as ready for review February 13, 2026 13:40
@sachmii sachmii requested a review from az108 as a code owner February 13, 2026 13:40
@github-actions
Copy link
Contributor

@sachmii Test coverage has been automatically updated in the PR description.

@github-actions
Copy link
Contributor

@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@github-actions
Copy link
Contributor

🤖 OpenAPI spec and client code auto-updated and committed.

@github-actions
Copy link
Contributor

@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@github-actions
Copy link
Contributor

🤖 No OpenAPI or client changes needed.

Copy link
Contributor

@Bofan-Zhu Bofan-Zhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. I left a few comments on the code (did not test it)

@sachmii sachmii requested a review from Bofan-Zhu February 13, 2026 14:07
@github-actions
Copy link
Contributor

@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@github-actions
Copy link
Contributor

🤖 No OpenAPI or client changes needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client Pull requests that update TypeScript code. (Added Automatically!) job Code changes in job module. ready for review server Pull requests that update Java code. (Added Automatically!) tests user management Code changes in user management module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Further employee fixes and adaptations

2 participants