`General`: Improve carousel in evaluation page by Bofan-Zhu · Pull Request #1823 · ls1intum/tum-apply

Bofan-Zhu · 2026-01-28T14:04:17Z

Checklist

General

I tested all changes and their related features with all corresponding user types.
Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
I chose a title conforming to the naming conventions for pull requests.

Server

Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
I strictly followed the principle of data economy for all database calls.
I strictly followed the server coding and design guidelines.
I documented the Java code using JavaDoc style.

Motivation and Context

The application cards in the review carousel currently lack substantive information, serving no clear purpose. We should surface the applicant's core details directly on the card to ensure key information is visible before the user starts scrolling.

Description

This PR:

adds avg rating to the application card
adds a rating util which converts the likert scale avg score -2 to +2 to a readable score 1 to 5
adds a star rating component with fill color corresponding to likert scale color
adds a profile image placeholder (needs to be replaced once users can upload their profile image) to the application card and to the application detail component for small screens
adjusts the layout of buttons

Steps for Testing

Prerequisites:

Log in to TumApply as Professor
Go to Application Review and view the card
Check that everything still works as before
Check application card with realistic data
Check avg rating: rate with professor and employee or more employees

Review Progress

Code Review

Code Review 1

Manual Tests

Test 1

Screenshots

github-actions · 2026-01-28T14:06:25Z

@Bofan-Zhu Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

github-actions · 2026-01-28T14:10:00Z

📊 Client Test Coverage Too Low

🔍 View coverage locally:

npm run test:ci
open build/test-results/lcov-report/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

github-actions · 2026-01-28T14:37:00Z

@Bofan-Zhu Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

github-actions · 2026-01-28T14:37:29Z

📊 Client Test Coverage Too Low

🔍 View coverage locally:

npm run test:ci
open build/test-results/lcov-report/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

github-actions · 2026-01-28T15:26:37Z

📊 Client Test Coverage Too Low

🔍 View coverage locally:

npm run test:ci
open build/test-results/lcov-report/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

github-actions · 2026-01-28T15:29:10Z

@Bofan-Zhu Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

github-actions · 2026-01-30T15:26:54Z

@Bofan-Zhu Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

github-actions · 2026-01-30T15:31:48Z

📊 Client Test Coverage Too Low

🔍 View coverage locally:

npm run test:ci
open build/test-results/lcov-report/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

github-actions · 2026-01-30T16:25:15Z

@Bofan-Zhu Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

github-actions · 2026-01-30T16:29:28Z

📊 Client Test Coverage Too Low

🔍 View coverage locally:

npm run test:ci
open build/test-results/lcov-report/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

github-actions · 2026-02-06T10:14:11Z

@Bofan-Zhu Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

github-actions · 2026-02-06T10:14:38Z

📊 Client Test Coverage Too Low

🔍 View coverage locally:

npm run test:ci
open build/test-results/lcov-report/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

github-actions · 2026-02-06T10:30:02Z

@Bofan-Zhu Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

github-actions · 2026-02-06T10:30:52Z

📊 Client Test Coverage Too Low

🔍 View coverage locally:

npm run test:ci
open build/test-results/lcov-report/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

github-actions · 2026-02-09T11:25:57Z

📊 Client Test Coverage Too Low

🔍 View coverage locally:

npm run test:ci
open build/test-results/lcov-report/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

github-actions · 2026-02-09T11:26:49Z

@Bofan-Zhu Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

github-actions · 2026-02-09T11:27:10Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-02-09T19:43:19Z

📊 Client Test Coverage Too Low

🔍 View coverage locally:

npm run test:ci
open build/test-results/lcov-report/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

github-actions · 2026-02-09T19:45:01Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-02-09T19:46:27Z

📊 Client Test Coverage Too Low

🔍 View coverage locally:

npm run test:ci
open build/test-results/lcov-report/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

github-actions · 2026-02-09T19:46:49Z

@Bofan-Zhu Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

github-actions · 2026-02-09T19:47:49Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-02-09T19:50:39Z

@Bofan-Zhu Test coverage has been automatically updated in the PR description.

github-actions · 2026-02-09T19:53:59Z

@Bofan-Zhu Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

github-actions · 2026-02-09T20:13:01Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-02-09T20:16:39Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-02-09T20:37:02Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-02-09T20:37:55Z

📊 Client Test Coverage Too Low

🔍 View coverage locally:

npm run test:ci
open build/test-results/lcov-report/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

github-actions · 2026-02-09T20:47:10Z

🤖 No OpenAPI or client changes needed.

Bofan-Zhu added 4 commits January 24, 2026 23:15

adjust carousel and add application header

447c678

test

8c476b2

Merge branch 'main' into 1763-improve-carouse-in-evaluation-page

0767c26

test

9e3ebc2

Bofan-Zhu linked an issue Jan 28, 2026 that may be closed by this pull request

Improve carouse in evaluation page #1763

Open

1 task

github-actions bot assigned Bofan-Zhu Jan 28, 2026

github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Jan 28, 2026

structure application card

7093ad6

Bofan-Zhu changed the title ~~1763 improve carouse in evaluation page~~ General: Improve carousel in evaluation page Jan 28, 2026

restructure applicant information

975a462

Merge branch 'main' into 1763-improve-carouse-in-evaluation-page

030316a

update application card

65f90c3

Bofan-Zhu added 2 commits February 6, 2026 09:17

Merge branch 'main' into 1763-improve-carouse-in-evaluation-page

51278cf

adjust buttons and text

47b6ad8

remove horizontal padding

ed224ff

adjust spacing

99e9833

add line clamp, adjust text break

47db9df

remove dates from card, add to detail

d22567e

helios-aet bot had a problem deploying to test-server February 9, 2026 19:43 Failure

fix eslint

fc2fa6e

Bofan-Zhu and others added 2 commits February 9, 2026 20:50

fix code style

2265810

Merge branch 'main' into 1763-improve-carouse-in-evaluation-page

e234e89

Bofan-Zhu added the shared Code changes in shared modules label Feb 9, 2026

helios-aet bot temporarily deployed to test-server February 9, 2026 19:59 Inactive

optimize

16b65de

fix logic

3af838c

add dynamic font size

79cdedf

Bofan-Zhu added the ready for review label Feb 9, 2026

Bofan-Zhu marked this pull request as ready for review February 9, 2026 20:35

Bofan-Zhu requested a review from az108 as a code owner February 9, 2026 20:35

fix tests

c2c3f48

Conversation

Bofan-Zhu commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

General

Server

Motivation and Context

Description

Steps for Testing

Review Progress

Code Review

Manual Tests

Screenshots

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Bofan-Zhu commented Jan 28, 2026 •

edited

Loading