fix(habits): handle commits without author to prevent undefined destr…#1764
Closed
calilkhalil wants to merge 1 commit intolowlighter:masterfrom
calilkhalil:fix/habits-undefined-author
Closed
fix(habits): handle commits without author to prevent undefined destr…#1764calilkhalil wants to merge 1 commit intolowlighter:masterfrom calilkhalil:fix/habits-undefined-author
calilkhalil wants to merge 1 commit intolowlighter:masterfrom
calilkhalil:fix/habits-undefined-author
Conversation
Author
|
Closing this PR as I discovered #1739 already addresses this exact issue. I'll add my support and testing feedback on that PR instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where the habits plugin crashes when encountering commits without an
authorproperty, which can occur with:Changes
commit?.authorexists before destructuringTypeError: Cannot destructure property 'author' of 'undefined'Testing
Tested with repositories containing fork commits and automated merge events.
Related Issue
Fixes the error:
TypeError: Cannot destructure property 'author' of 'undefined' at file:///metrics/source/plugins/habits/index.mjs:51:21